Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Forbidden in dataset create error catching #85

Conversation

loveeklund-osttra
Copy link
Contributor

Solves issues #84

@z3z1ma
Copy link
Owner

z3z1ma commented Apr 25, 2024

Thanks, good thinking. I am curious on what the exception trace looks like when the dataset both doesn't exist and you don't have permission to create it. Since at that point we hit the Forbiddenhandling code path and call .get_dataset. We could probably catch it and log something simple and direct on how the user can fix this by updating SA permissions or creating the dataset ahead of time. But its more of a nit. LGTM.

@z3z1ma z3z1ma merged commit 654920c into z3z1ma:main Apr 25, 2024
@loveeklund-osttra loveeklund-osttra deleted the feature/catch_error_from_missing_permission_bigquery_datasets_create branch September 17, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants