New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Escaping table identifiers for deduplication and overwrite cases #38

Merged

z3z1ma merged 1 commit into z3z1ma:main from emishas:fix-overwrite-dedup-config

May 8, 2023

Contributor

emishas commented May 1, 2023

Expanding this fix to these configurations

overwrite=true
dedupe_before_upsert=true


          patch: Escaping table identifiers for deduplication and overwrite cases

48fe0cf

emishas commented

View reviewed changes

target_bigquery/core.py

@@ @@ -500,9 +500,9 @@ def clean_up(self) -> None: @@
                           if self._is_dedupe_before_upsert_candidate():
                               # We can't use MERGE with a non-unique key, so we need to dedupe the temp table into
                               # a _SESSION scoped intermediate table.
-                              tmp = f"{target.name}__tmp"
+                              tmp = f"{self.merge_target.name}__tmp"

Contributor Author

emishas May 1, 2023

target is of Table type that doesn't have a name property, merge_target (BigQueryTable type) has.

z3z1ma merged commit e1b4ee1 into z3z1ma:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet