Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuration of Bigquery dataset location #13

Conversation

VinceLegendre
Copy link
Contributor

@VinceLegendre VinceLegendre commented Feb 1, 2023

Simple PR to enable the configuration of BigQuery data location

Notes:

  • tests passed
  • default location to "US"
  • setting the location parameter has no effect if the dataset already exists

[EDIT]:

  • added support for GCS bucket location configuration
  • ensure that both the dataset and the GCS bucket comply the location specification

Best,
Vincent

- Bigquery dataset location
- GCS bucket location
- Ensure that both GCS bucket and BigQuery dataset are in the same location
- Tests passed
@VinceLegendre VinceLegendre force-pushed the add-support-for-dataset-location-configuration branch from d2abb5b to f60d702 Compare February 2, 2023 16:20
@z3z1ma
Copy link
Owner

z3z1ma commented Feb 3, 2023

This is 🔥

Thanks for the contribution @VinceLegendre

@z3z1ma z3z1ma merged commit 5a884b2 into z3z1ma:main Feb 3, 2023
@VinceLegendre VinceLegendre deleted the add-support-for-dataset-location-configuration branch February 3, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants