-
Notifications
You must be signed in to change notification settings - Fork 5
Capability refactor #53
base: master
Are you sure you want to change the base?
Conversation
added ZOCPParameterList class for tracking ZOCPParameters ZOCPParameter is now maintaining the list of parameters by itself
added __repr__
value was missing in dict output added __dict__ method changed __repr__ method to out class instance syntax
added dict output test skipped serialize test as it is kind of difficult and not needed (yet)
replaced capabilty dictionary construction with ZOCPParameter class
Ow btw a discussion was at #42 |
…iple nodes in one process). It's now done through members passed to the class (for testing) or retrieved from the zocp instance passed to the class (_params_list, _monitor_subscribers) removed self.subscriptions, not needed and done by the zocp class added (un)subscribe_receiver methods, replaces signal_subscribe* methods refactored unittest to reflect changes
register methods now return a ZOCPParameter signal methods now work with signal ids and ZOCPParameter instances emit_signal method is deprecated self.subscribers -> self.monitor_subscribers = set() fix monitor_subscribers var name refactored unittest to reflect changes
The travis fail was because of zeromq/pyre#48 |
Been testing with the node editor. Actually got quite far :) Nodes show up in the editor and I can manage subscriptions. However editing from the urwid monitor:
subscribee doesn't show up in urwid. |
also an error in urwid on nodeeditor exit: |
… into capability_refactor
fixed set_object fixed _on_modified argument in signal_(un)subscribe removed unittest skips some tweaking of monitor subscribe test as the monitor needs some time to get messages from nodes
changed example to use signal ids
changed signal_monitor test to give more chance for messages to arrive
I don't understand why travis is failing:
those are weird errors which I can' reproduce |
A combination of these tests gives an exception sometimes:
Upgraded zmq to 4.1 and now running without trouble.... weird. Might cause travis build fail as well |
After a long run I still got an error:
seems the frontend is waiting for the backend to signal stop however either the frontend or the backend is already gone |
Implemented a ZOCPParameter class with necessary functionality. It tracks a list of parameters by itself including the id's.
unittests are ok (hopefully travis as well). It still needs work on the signals!