Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pass language to markdown-pdf puppeteer #172

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Conversation

martilidad
Copy link
Contributor

this fixes #95

@martilidad martilidad requested a review from yzane January 20, 2020 22:35
@yzane yzane added this to the 1.4.2 milestone Feb 11, 2020
@yzane yzane merged commit b814f8c into yzane:master Feb 16, 2020
@yzane
Copy link
Owner

yzane commented Feb 16, 2020

Thanks for your PR!

@fuhrmanator
Copy link

fuhrmanator commented Feb 6, 2022

Apart from the typo with vscode.env.langauage (maybe I'm wrong about that), vscode.env.language seems to only be configurable to en but not en-CA or en-AU. https://code.visualstudio.com/docs/getstarted/locales

I'm in Quebec, which can be both English and French, so if I set my locale to French in VSCode, I get a date that looks great: 06/02/2022 (dd/mm/yyyy) which is consistent with fr and also en-CA (but I can't see how to set the latter in VScode).

How does @martilidad specify a VSCode local of en-AU (as in the example of #95)?

@martilidad
Copy link
Contributor Author

martilidad commented Feb 6, 2022

This was a dirty fix at the time, because I just wanted to export a markdown with the correct date format myself and just quickly pushed a commit here to try to help. It seems that vscode may have changed something about how to set languages/how it stores the user language.

The easiest fix would be to have a separate plugin setting for the format and/or language passed to the pupetteer. (e.g. markdown-pdf.export-locale)
This is probably an easy first issue @fuhrmanator .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date Format
4 participants