Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First H1 header not recognized if file starts with UTF-8 BOM #44

Closed
sba923 opened this issue Nov 28, 2017 · 2 comments
Closed

First H1 header not recognized if file starts with UTF-8 BOM #44

sba923 opened this issue Nov 28, 2017 · 2 comments

Comments

@sba923
Copy link

sba923 commented Nov 28, 2017

If the .md file is encoded as "UTF-8 with BOM", then the extension doesn't correctly convert the first H1 header (see example).

test.pdf
test.zip

The extension should be modified so that it ignores the BOM when parsing the file's contents.
yzane added a commit that referenced this issue Apr 30, 2018
@yzane
Fix: File encoding #39 #44
d47b11f
@yzane
Copy link
Owner

yzane commented Apr 30, 2018

Please upgrade to Markdown PDF ver1.0.3 and try it.

@yzane yzane closed this as completed Apr 30, 2018
@sba923
Copy link
Author

sba923 commented Jul 9, 2018

Indeed, can't repro anymore with v1.2.0. Thanks for the fix.

tat3 pushed a commit to tat3/vscode-markdown-pdf-2 that referenced this issue Sep 4, 2022
@yzane
Fix: File encoding yzane#39 yzane#44
1544d59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sba923 @yzane