Add a new struct: StartingPoint #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This struct is intended for a caller of `Finder` to specify the correct `starting_point` in advance. **The correct `starting_point`** means the path which is valid in terms of character encdoing, and really exists in a file system; in other words, it can be `canonicalize`d safely. With this refactoring, each `ConsumedDir` does not have to call `canonicalize` because `Finder` can get absolute path due to the `canonicalize`d `starting_point`.
yykamei
added
the
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This struct is intended for a caller of
Finderto specify the correctstarting_pointin advance. The correctstarting_pointmeans thepath which is valid in terms of character encdoing, and really exists in
a file system; in other words, it can be
canonicalized safely.With this refactoring, each
ConsumedDirdoes not have to callcanonicalizebecauseFindercan get absolute path due to thecanonicalizedstarting_point.