Fix #5, #3 and bdprochot_on.sh #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be used on different platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5 by and with 0xFFFFFE instead of 0xFFFFE. This is needed on some platform such as intel core i7 1165G7. This will not influence those working platforms since and with operation will ignore the superfluous F.
Fix #3 by using plain decimal value when write back to reg. For more background, see #3.
Fix the output of bdprochot_off.sh. It is the $f variable instead of the $s variable that is written to the reg, so I change $s to $f in the output.
Fix the bdprochot_on.sh. The old script write a fix value to the reg, which doesn't work for most of the platforms. I change it to calculate the correct value so that it can be used on any platform.
I have tested the scripts on intel core i7 1165G7. The original value of reg 0x1FC is 0x24005b. After running bdprochot_off.sh, it changed to 0x24005a, showing that the bit[0] had been set to 0. Then run bdprochot_on.sh and it recovered to 0x24005b.