Fix reading/writing of library.last_played_at #10
Conversation
src/library/basetracktablemodel.cpp
Outdated
| QDateTime lastPlayedAt; | ||
| if (rawValue.type() == QVariant::String) { | ||
| // column value | ||
| lastPlayedAt = sqlite::readGeneratedTimestamp(rawValue); |
There was a problem hiding this comment.
The current state is that "2020-12-23T23:41:50.294" format is also written as string into the Library.
That fails here. So we need to delay this PR and its DB repair code until this issue is solved.
Else users will not see a time stamp for recently played tracks.
There was a problem hiding this comment.
??? This PR fixes all formatting issues and fixes the wrong values in the DB. I don't understand what you ask here for.
There was a problem hiding this comment.
Oh sorry, I was confused, because I have used a unpatched version after the new library migration.
I have now tested again and I can't see any T splitter formats anymore. The offset issue is also entirely solved.
QStringBuilder doesn't work for constants!
src/library/basetracktablemodel.cpp
Outdated
| QDateTime lastPlayedAt; | ||
| if (rawValue.type() == QVariant::String) { | ||
| // column value | ||
| lastPlayedAt = sqlite::readGeneratedTimestamp(rawValue); |
There was a problem hiding this comment.
Oh sorry, I was confused, because I have used a unpatched version after the new library migration.
I have now tested again and I can't see any T splitter formats anymore. The offset issue is also entirely solved.
|
|
||
| } // namespace | ||
|
|
||
| namespace sqlite { |
There was a problem hiding this comment.
we should probably make this mixxx::sqlite so there isn't confusion that this is an official sqlite namespace
|
thanks! |
|
When does last_played_at get initially populated? Starting from a fresh db all the values are empty... now that we persist in the db we need to generate the values when we upgrade the db, right? (@uklotzde ) |
|
oh nevermind I see what I need to do |
…h sync
When loading a track that is not yet present in the library (and thus
doesn't have any BPM because it hasn't been analyzed yet) while another
deck is playing and both decks have sync enabled, a debug assertion is
triggered:
DEBUG ASSERT: "isValid()" in function double mixxx::Bpm::value() const at src/track/bpm.h:53
Aborted (core dumped)
The backtrace looks as follows:
#0 0x00007f175c87234c in __pthread_kill_implementation () at /usr/lib/libc.so.6
#1 0x00007f175c8254b8 in raise () at /usr/lib/libc.so.6
#2 0x00007f175c80f534 in abort () at /usr/lib/libc.so.6
#3 0x00007f175cf05ee4 in qt_assert(char const*, char const*, int) () at /usr/lib/libQt5Core.so.5
#4 0x000055deb2e67e1c in mixxx::(anonymous namespace)::handleMessage(QtMsgType, QMessageLogContext const&, QString const&) (type=<optimized out>, context=<optimized out>, input=<optimized out>) at src/util/logging.cpp:355
#5 0x00007f175cf47128 in () at /usr/lib/libQt5Core.so.5
#6 0x00007f175cf3fd8a in () at /usr/lib/libQt5Core.so.5
#7 0x00007f175cf06526 in QMessageLogger::critical(char const*, ...) const () at /usr/lib/libQt5Core.so.5
#8 0x000055deb2e5c720 in mixxx_debug_assert(char const*, char const*, int, char const*) (assertion=assertion@entry=0x55deb39bd0db "isValid()", file=file@entry=0x55deb39bbf30 "src/track/bpm.h", line=line@entry=53, function=function@entry=0x55deb39bbf08 "double mixxx::Bpm::value() const") at gsrc/util/assert.h:9
#9 0x000055deb2ee7e7e in mixxx_debug_assert_return_true(char const*, char const*, int, char const*) (function=0x55deb39bbf08 "double mixxx::Bpm::value() const", line=53, file=0x55deb39bbf30 "src/track/bpm.h", assertion=0x55deb39bd0db "isValid()") at gsrc/util/assert.h:18
#10 mixxx::Bpm::value() const (this=<synthetic pointer>) at src/track/bpm.h:53
#11 mixxx::operator*(mixxx::Bpm, double) (multiple=1, bpm=...) at src/track/bpm.h:160
#12 SyncControl::setLocalBpm(mixxx::Bpm) (this=<optimized out>, localBpm=...) at src/engine/sync/synccontrol.cpp:567
mixxxdj#13 0x000055deb34c7ba3 in EngineBuffer::postProcess(int) (this=0x55deb56eb060, iBufferSize=2048) at src/engine/enginebuffer.cpp:1318
mixxxdj#14 0x000055deb3139023 in EngineMaster::processChannels(int) (this=0x55deb5449440, iBufferSize=<optimized out>) at src/engine/enginemaster.cpp:383
mixxxdj#15 0x000055deb31394f7 in EngineMaster::process(int) (this=0x55deb5449440, iBufferSize=iBufferSize@entry=2048) at src/engine/enginemaster.cpp:410
mixxxdj#16 0x000055deb2f91d0b in SoundManager::onDeviceOutputCallback(long) (this=<optimized out>, iFramesPerBuffer=iFramesPerBuffer@entry=1024) at src/soundio/soundmanager.cpp:596
mixxxdj#17 0x000055deb32dd794 in SoundDevicePortAudio::callbackProcessClkRef(long, float*, float const*, PaStreamCallbackTimeInfo const*, unsigned long) (this=0x55deb553e6b0, framesPerBuffer=1024, out=<optimized out>, in=<optimized out>, timeInfo=<optimized out>, statusFlags=<optimized out>) at src/soundio/sounddeviceportaudio.cpp:965
This happens because `newLocalBpm` is invalid when `localBpm` is
invalid. Trying to do sync decks while no tempo information is available
does not make sense, so we only synchronize decks if the local BPM is
available.
No description provided.