reenable plainactionfuture assertion

ywangd · Oct 9, 2024 · c6d7524 · c6d7524
1 parent 3b37f43
commit c6d7524
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/server/src/main/java/org/elasticsearch/action/support/PlainActionFuture.java b/server/src/main/java/org/elasticsearch/action/support/PlainActionFuture.java
@@ -20,6 +20,8 @@
 import org.elasticsearch.common.util.concurrent.UncategorizedExecutionException;
 import org.elasticsearch.core.Nullable;
 import org.elasticsearch.core.TimeValue;
+import org.elasticsearch.logging.LogManager;
+import org.elasticsearch.logging.Logger;
 import org.elasticsearch.threadpool.ThreadPool;
 import org.elasticsearch.transport.Transports;
 
@@ -31,6 +33,7 @@
 import java.util.concurrent.locks.AbstractQueuedSynchronizer;
 
 public class PlainActionFuture<T> implements ActionFuture<T>, ActionListener<T> {
+    private static final Logger logger = LogManager.getLogger(PlainActionFuture.class);
 
     @Override
     public void onResponse(@Nullable T result) {
@@ -39,7 +42,12 @@ public void onResponse(@Nullable T result) {
 
     @Override
     public void onFailure(Exception e) {
-        // assert assertCompleteAllowed();
+        try {
+            assert assertCompleteAllowed();
+        } catch (AssertionError ae) {
+            logger.info("--> AssertionError while onFailure", e);
+            throw ae;
+        }
         if (sync.setException(Objects.requireNonNull(e))) {
             done(false);
         }