merge master

.azure-pipelines/PrettierCheck.yml

@@ -1,6 +1,5 @@
 jobs:
 - job: "PrettierCheck"
-  condition: "not(variables['PRIVATE'])"
   variables:
     NODE_OPTIONS: '--max-old-space-size=8192'
   pool:

.azure-pipelines/SDKAutomation.yml

@@ -20,7 +20,6 @@ jobs:
 
   variables:
       NODE_OPTIONS: '--max-old-space-size=8192'
-      BLOB_STORAGE_PREFIX: sdkautomation-pipeline
       SPEC_REPO: $(Build.Repository.Name)
       PR_NUMBER: $(System.PullRequest.PullRequestNumber)
       BUILD_ID: $(Build.BuildId)
@@ -42,6 +41,8 @@ jobs:
         SDK_REPO_NAME: azure-sdk-for-go
       Trenton:
         SDK_REPO_NAME: azure-sdk-for-trenton
+      Schema:
+        SDK_REPO_NAME: azure-resource-manager-schemas
   steps:
   - checkout: none
   - script: |
@@ -62,22 +63,30 @@ jobs:
     displayName: Pull SDK Automation Image
   - script: |
       docker run \
+        -e BLOB_PROXY_PREFIX \
+        -e BLOB_STORAGE_PREFIX \
+        -e BLOB_STORAGE_IS_PUBLIC \
+        -e BLOB_DOWNLOAD_COMMAND \
         -e BLOB_STORAGE_NAME \
         -e BLOB_STORAGE_KEY \
         -e GITHUB_COMMENT_AUTHOR_NAME \
         -e GITHUBAPP_ID \
         -e GITHUBAPP_PRIVATE_KEY \
         -e NODE_OPTIONS \
-        -e BLOB_STORAGE_PREFIX \
         -e SPEC_REPO \
         -e PR_NUMBER \
         -e SDK_REPO_NAME \
         -e AZURE_DEVOPS_EXT_PAT \
         -e BUILD_ID \
         sdk-automation:latest npm start
+    condition: or(ne(variables['SDK_REPO_NAME'], 'azure-resource-manager-schemas'), endsWith(variables['SPEC_REPO'], '/azure-rest-api-specs'))
     env:
       BLOB_STORAGE_NAME: $(blob-storage-name)
       BLOB_STORAGE_KEY: $(blob-storage-key)
+      BLOB_STORAGE_PREFIX: $(blob-storage-prefix)
+      BLOB_PROXY_PREFIX: $(blob-proxy-prefix)
+      BLOB_STORAGE_IS_PUBLIC: $(blob-is-public)
+      BLOB_DOWNLOAD_COMMAND: $(blob-download-command)
       GITHUB_COMMENT_AUTHOR_NAME: $(github-comment-author-name)
       GITHUBAPP_ID: $(githubapp-id)
       GITHUBAPP_PRIVATE_KEY: $(githubapp-private-key)

.azure-pipelines/Spellcheck.yml

@@ -1,6 +1,5 @@
 jobs:
 - job: "Spellcheck"
-  condition: "not(variables['PRIVATE'])"
   variables:
     NODE_OPTIONS: '--max-old-space-size=8192'
   pool:

.azure-pipelines/azure-pipelines-data-container.yml

@@ -39,4 +39,3 @@ steps:
     repository: $(CONTAINER_REGISTRY_REPOSITORY_NAME)
     tags: |
       latest
-      $(IMAGE_TAG_PREFIX)$(Build.BuildNumber)

.github/CONTRIBUTING.md

@@ -1,3 +1,3 @@
-### *This is an outdated document. Please refer the new [wiki](https://github.com/Azure/adx-documentation-pr/wiki) for up to date details.* 
+### *This is an outdated document. Please refer the new [wiki](https://github.com/Azure/azure-rest-api-specs/wiki) for up to date details.* 
 ([`Link your GitHub account`](https://repos.opensource.microsoft.com/) to the 'Azure' organization for access.)
 

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,8 +1,29 @@
 <i>MSFT employees can try out our new experience at <b>[OpenAPI Hub](https://aka.ms/openapiportal) </b> - one location for using our validation tools and finding your workflow. 
 </i>
 
+### Changelog
+Please ensure to add changelog with this PR by answering the following questions.
+  1. What's the purpose of the update?    
+      - [ ] new service onboarding 
+      - [ ] new API version 
+      - [ ] update existing version for new feature 
+      - [ ] update existing version to fix swagger quality issue in s360
+      - [ ] Other, please clarify 
+  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
+  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
+  4. If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.
+      - [ ] SDK of .NET (need service team to ensure code readiness)
+      - [ ] SDK of Python
+      - [ ] SDK of Java
+      - [ ] SDK of Js
+      - [ ] SDK of Go
+      - [ ] PowerShell
+      - [ ] CLI
+      - [ ] Terraform
+      - [ ] No, no need to refresh for updates in this PR
+
 ### Contribution checklist:
-- [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of “no breaking changes
+- [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of "no breaking changes"
 - [ ] I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow.
 - [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and errors have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
 
@@ -12,17 +33,22 @@ If any further question about AME onboarding or validation tools, please view th
 - [ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
   - Adding new API(s)
   - Adding a new API version
+  -  [ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
   - Adding a new service
 
+- [ ] Please ensure you've reviewed following [guidelines](https://aka.ms/rpguidelines) including [ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and [REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md). Estimated time (4 hours). This is required before you can request review from ARM API Review board.
+
 - [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them. 
 
 ### Breaking Change Review Checklist 
-If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi). 
+If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi). 
 
 - [ ] Removing API(s) in stable version
 - [ ] Removing properties in stable version
 - [ ] Removing API version(s) in stable version
-- [ ] Updating API in stable version with Breaking Change Validation errors
-- [ ] Updating API(s) in preview over 1 year
+- [ ] Updating API in stable or public preview version with Breaking Change Validation errors
+- [ ] Updating API(s) in public preview over 1 year (refer to [Retirement of Previews](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37683/Retirement-of-Previews))
+
+**Action**: to initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).
 
-Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview).
+Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview).

.github/comment.yml

@@ -0,0 +1,64 @@
+---
+- rule:
+    type: checkbox
+    keywords:
+      - "WaitForARMFeedback"
+    booleanFilterExpression: "!(ARMSignedOff||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)"
+    onCheckedLabels:
+      - WaitForARMFeedback
+    onCheckedComments: "Hi, @${PRAuthor} your PR are labelled with <b> WaitForARMFeedback</b>. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @${PRAssignee} "
+
+- rule:
+    type: label
+    label: BreakingChangeReviewRequired
+    variables:
+        openapiHub: https://portal.azure-devex-tools.com
+    onLabeledComments: "Hi @${PRAuthor}, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review. </br>**Action**: To initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).</br> If you want to know the production traffic statistic, please see [ARM Traffic statistic](${openapiHub}/api/pr/query-traffic?pr=${owner}/${repo}/${PRNumber}&days=5). </br> If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback."
+
+- rule:
+    type: label
+    repoAllowList:
+      - Azure/azure-rest-api-specs-pr
+    variables:
+      openapiHub: https://portal.azure-devex-tools.com
+      to: Azure/azure-rest-api-specs/master
+    label: Approved-OkToMerge
+    onLabeledComments: "Hi @${PRAuthor},Your PR is approved. Congratulations. </br>  <li> Since your PR is in private repo (azure-rest-api-specs-pr),  there won’t be PR merge. If you want to publish the PR to public repo (Azure/azure-rest-api-specs) and get it merged, pls use [OpenAPIHub Publish PR](${openapiHub}/tools/publishpullrequest?pr=${owner}/${repo}/${PRNumber}&to=${to}).</li> <li> For further guidance on how to proceed.  Please refer to this [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/205/RP-Scenarios-to-Contribute-to-Swagger?anchor=**public-repository-vs.-private-repository**)</li>"
+
+- rule:
+    type: label
+    label: NewApiVersionRequired
+    onLabeledComments: "<b>NewApiVersionRequired reason:</b></br> </br><b>A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. </b> </br></br> EXAMPLE: if a customer calls a service in the public cloud using <b>api-version=2020-07-27</b>, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.  "
+
+- rule:
+    type: label
+    label: CI-FixRequiredOnFailure
+    onLabeledComments: >- 
+      Hi @${PRAuthor}, Your PR has some issues. Please fix the CI sequentially by following the order of `Avocado, semantic validation, model validation, breaking change, lintDiff`. 
+      <table><tr><th>Task</th><th>How to fix</th><th>Priority</th><th>Support (Microsoft alias)</th></tr>
+      <tr><td>Avocado</td><td>[Fix-Avocado](https://github.com/Azure/avocado)</td><td>High</td><td>ruowan</td></tr>
+      <tr><td>Semantic validation</td><td>[Fix-SemanticValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#semantic-validation)</td><td>High</td><td>raychen, jianyxi</td></tr>
+      <tr><td>Model validation</td><td>[Fix-ModelValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#model-validation)</td><td>High</td><td>raychen,jianyxi</td></tr>
+      <tr><td>LintDiff</td><td>[Fix-LintDiff](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#linter-validation)</td><td>high</td><td>jianyxi, ruoxuan</td></tr></table> 
+      If you need further help, please feedback via [swagger feedback](https://aka.ms/swaggerfeedback)." 
+
+- rule:
+    type: PROpen
+    variables:
+      openapiHub: https://portal.azure-devex-tools.com
+    keywords:
+      - "I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow."
+    onOpenedComments: "Hi, @${PRAuthor} Thanks for your PR. I am workflow bot for review process. Here are some small tips. </br> <li> Please ensure to do self-check against checklists in first PR comment.</li> <li> PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging. </li>   <li> For specs comparison cross API versions,  Use [API Specs Comparison Report Generator](${openapiHub}/tools/diff?pr=${owner}/${repo}/${PRNumber})</li>  <li> If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. [How to fix?](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md)</li></br> Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]"
+
+- rule:
+    type: PROpen
+    onOpenedComments: "[Call for Action] To better understand Azure service dev/test scenario,  and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase.  It will take 5 to 10 minutes.  If you already complete survey, please neglect this comment.  Thanks."
+
+
+- rule:
+    type: checkbox
+    keywords:
+      - "update existing version to fix swagger quality issue in s360"
+    onCheckedLabels:
+      - FixS360
+

.github/issue_assignment.yml

@@ -2,20 +2,11 @@
 - rule:
     booleanFilterExpression: "needs-triage"
     assignees:
-      - yungezz
-      - erich-wang
-      - NullMDR
+      - PhoenixHe-msft
       - raych1
-      - lirenhe
-      - weidongxu-microsoft
-      - ArcturusZhang
-      - xccc-msft
-      - ChenTanyi
-      - fengzhou-msft
-      - njuCZ
       - akning-ms
-      - markcowl
       - leni-msft
-      - qianwens
       - ruowan
-      - MyronFanQiu
+      - jianyexi
+      - zhenglaizhang
+