Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle permission errors and stale file errors better #7

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

yuvipanda
Copy link
Owner

@yuvipanda yuvipanda commented Nov 14, 2023

Ref #6
Ref #5

@yuvipanda
Copy link
Owner Author

This is actually not quite right, as it just ignores an entire subtree the first time any errors are noticed.

Copy link

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incremental improvement as long as we don't loose track of the need to iterate on this based on [...] it just ignores an entire subtree the first time any errors are noticed. I opened #10 for this for now as I couldn't come up with a quick resolution.

Title suggestion: Handle permission errors and stale file errors better

@consideRatio
Copy link

Thank you for working this @yuvipanda!!! ❤️ 🎉

@consideRatio
Copy link

consideRatio commented Mar 16, 2024

@yuvipanda let's go for a merge here and flush this incremental improvement, #10 captures the comment about "its not quite right".

@yuvipanda yuvipanda changed the title Handle 2 reported errors better Handle permission errors and stale file errors better Mar 19, 2024
@yuvipanda yuvipanda merged commit 15d717d into main Mar 19, 2024
@yuvipanda
Copy link
Owner Author

Yeah, I've changed the 'fixes' to 'ref' and merged this for now, even though it's going in the wrong direction for error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants