-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle permission errors and stale file errors better #7
Conversation
8fc1014
to
62659f4
Compare
This is actually not quite right, as it just ignores an entire subtree the first time any errors are noticed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an incremental improvement as long as we don't loose track of the need to iterate on this based on [...] it just ignores an entire subtree the first time any errors are noticed
. I opened #10 for this for now as I couldn't come up with a quick resolution.
Title suggestion: Handle permission errors and stale file errors better
Thank you for working this @yuvipanda!!! ❤️ 🎉 |
@yuvipanda let's go for a merge here and flush this incremental improvement, #10 captures the comment about "its not quite right". |
Yeah, I've changed the 'fixes' to 'ref' and merged this for now, even though it's going in the wrong direction for error handling. |
Ref #6
Ref #5