Skip to content

Commit

Permalink
Set a tiny CPU guarantee for all user pods
Browse files Browse the repository at this point in the history
When limit is set but not guarantee, guarantee is set to match limit! For most
use cases, when we set limit but not guarantee, we want to offer no guarantee and
a limit. This doesn't seem to be possible at all (need to investigate why). In the
meantime, setting a super low guarantee here means we can guard against issues like
2i2c-org#790, where setting the limit
but not guarantee just gave users a huge guarantee, causing node spin ups to fail

Ref 2i2c-org#790
  • Loading branch information
yuvipanda committed Nov 1, 2021
1 parent a0d588a commit 8537c95
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions hub-templates/basehub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,14 @@ jupyterhub:
memory:
guarantee: 256M
limit: 1G
cpu:
# When limit is set but not guarantee, guarantee is set to match limit! For most
# use cases, when we set limit but not guarantee, we want to offer no guarantee and
# a limit. This doesn't seem to be possible at all (need to investigate why). In the
# meantime, setting a super low guarantee here means we can guard against issues like
# https://github.com/2i2c-org/infrastructure/issues/790, where setting the limit
# but not guarantee just gave users a huge guarantee, causing node spin ups to fail
guarantee: 0.01
networkPolicy:
# Allow unrestricted access to the internet but not local cluster network
enabled: true
Expand Down

0 comments on commit 8537c95

Please sign in to comment.