Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codestyle check by removing concurrent newlines #2

Closed
wants to merge 70 commits into from
Closed

Fix codestyle check by removing concurrent newlines #2

wants to merge 70 commits into from

Conversation

CapChrisCap
Copy link

Description

Fixed the minor issue that was also reported on Slack: https://trinodb.slack.com/archives/C0305TQ05KL/p1693386128831189

Command example)

. /mvnw clean install -Dcheckstyle.skip=true -DskipTests -am -pl :trino-snowflake

Current error

[INFO] There is 1 error reported by Checkstyle 10.12.0 with checkstyle/airbase-checks.xml ruleset.
[ERROR] src/test/java/io/trino/plugin/snowflake/TestSnowflakeTypeMapping.java:[340] (regexp) RegexpMultiline: Multiple consecutive blank lines

After removing the newlines, the error is resolved

yuuteng and others added 30 commits July 10, 2023 19:03
@yuuteng
Add Snowflake JDBC Connector
b400210
@yuuteng
Update trino snapshot version to 372
8700342
@yuuteng
Update format of the doc of snowflake
4e08543
@yuuteng
Update trino jdbc library import
2d84c9c
@yuuteng
Fix date formatter from yyyy to uuuu
df116e0
@yuuteng
Fix date test case
911f8dd
@yuuteng
Remove defunct property allow-drop-table
2ace2a8
@yuuteng
Update trino version to 374
8b3cfe3
@yuuteng
Update snowflake config to adapt 374
d84861d
@yuuteng
Update the range of the test of Date type
293895d
@yuuteng
Update to version 375
c0efb5a
@yuuteng
Fix snowflake after updating to 375
b26e2b6
@yuuteng
Update to 381
352b974
@yuuteng
Fix mvn pom import
4dcb1fd
@yuuteng
Format snowflake.rst
5059d93
@yuuteng
Reorderd Data tests in type mapping
fc60485
@yuuteng
Update function code
8d4dccf
@yuuteng
Add product test
d2fe5e6
@yuuteng
Rename product test tablename
1630237
@yuuteng
Add Env, Suite and properties of Snowflake for production test
4379c2f
@yuuteng
Add trinoCreateAndInsert()
9bdc981
@yuuteng
Refactor snowflake from single node to multi node
15efc78
@yuuteng
Pass product tests
fa70405
@yuuteng
Removed snowflake.properties in trino server dev
b709095
@yuuteng
Resolved issues 19 05 2022 and fixed tests
e59ed06
@yuuteng
Remove Types.VARBINARY
9476718
@yuuteng
Add private static SliceWriteFunction charWriteFunction
9f77c49
@yuuteng
Update test case
6de2b42
@yuuteng @ebyhr
Update plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake…
187dfe1 
…/SnowflakeClient.java

Co-authored-by: Yuya Ebihara <[email protected]>
@yuuteng @ebyhr
Update docs/src/main/sphinx/connector/snowflake.rst
171c932 
Co-authored-by: Yuya Ebihara <[email protected]>
yuuteng and others added 25 commits July 10, 2023 19:03
@yuuteng
Update and fix errors
38539f9
@yuuteng
Build successfully with 411
dc08bda
@dprophet @yuuteng
Adding Bloomberg Snowflake connector.
2fb9812 
Fully tested with Trino 406. Untested with 410.
@dprophet @yuuteng
Adding varchar type to mapping Snowflake.
38cc79f 
Adding --add-opens to enable support for Apache Arrow via shared memory buffers.
@dprophet @yuuteng
Fixing some tests.
64ad8cd
@yuuteng
Fix TestSnowflakeConnectorTest.
e52bdce 
TODO: testDataMappingSmokeTest: time and timestamp
testSetColumnTypes: time and timestamp
@yuuteng
Fix type mapper
43b85cd
@yuuteng
Fix testconnector
1d2f25f
@yuuteng
Update version to 413-SNAPSHOT
f36ed98
@yuuteng
Add product test
6493cb6
@yuuteng
Add Env, Suite and properties of Snowflake for production test
c2a6fe5
@yuuteng
Refactor snowflake from single node to multi node
3b462b3
@yuuteng
Removed snowflake.properties in trino server dev
8909bc3
@yuuteng
Renamed properties in Testing
69c9d3b
@yuuteng
Revert "Renamed properties in Testing"
923882a 
This reverts commit 82f9eb3f3811e8d90a482f5359e98e7c729afa17.
@yuuteng
Update and fix errors
643064e
@dprophet @yuuteng
Adding Bloomberg Snowflake connector.
a12a5f6 
Fully tested with Trino 406. Untested with 410.
@dprophet @yuuteng
Added support for HTTP_PROXY testing.
6949fd8
@dprophet @yuuteng
Connector doesnt support setColumnType. This causes lots of problems …
e3f70a5 
…with Snowflake server.

Disabled the testsetColumnTypes testing.
@yuuteng
Fixed and skipped error tests
4dc87d5
@yuuteng
Updated to 422
e7ff72a
@yuuteng
Updated and fixed
befa8a0
@yuuteng
Fix trino review 13-07-2023
5df374d
@yuuteng
Add timestamp tests
5520b5f
@CapCaWork
Fix codestyle check by removing concurrent newlines
49083ad
@yuuteng yuuteng force-pushed the bloomberg-snowflake branch from 5520b5f to b10a001 Compare October 31, 2023 12:05
@yuuteng yuuteng deleted the branch yuuteng:bloomberg-snowflake December 4, 2023 10:40
@yuuteng yuuteng closed this Dec 4, 2023
dprophet added a commit that referenced this pull request Dec 5, 2023
@dprophet
Merge pull request #2 from yuuteng/feature/2551-add-snowflake-connector
901aa0b 
Feature/2551 add snowflake connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CapChrisCap @yuuteng @dprophet @CapCaWork