Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema logic #61

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix schema logic #61

merged 1 commit into from
Sep 17, 2024

Conversation

willflet
Copy link
Contributor

  • Update regex pattern matching to play nicely with enum
  • Remove personal.info.custom-* fields from required info

@willflet willflet requested a review from yunanwg as a code owner September 17, 2024 00:15
@willflet
Copy link
Contributor Author

New document using this template throws errors when validating schema:

Screenshot 2024-09-17 011824

@yunanwg
Copy link
Owner

yunanwg commented Sep 17, 2024

Nice catch @willflet! I always wanted to take a look at the schema but was wondering if anyone is making use of it.

Thanks for the PR and LGTM!

@yunanwg yunanwg merged commit 8ca9217 into yunanwg:main Sep 17, 2024
1 check passed
@willflet willflet deleted the schema_validation_fix branch December 13, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunanwg yunanwg Awaiting requested review from yunanwg

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willflet @yunanwg