Fix empty line detection in markdown in list #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelbilek
force-pushed
the
fix-nested-codeblock-empty
branch
3 times, most recently
from
5827b8b to
965f08a
Compare
Fix for independent issue in yuin#177 The next parser should have the whitespace removed, even when it's blank
karelbilek
force-pushed
the
fix-nested-codeblock-empty
branch
from
965f08a to
c53c1a4
Compare
|
Rebased, fixed the test so they actually test the bug |
|
@yuin planning to merge this? (sorry for pushing :D ) |
13rac1
approved these changes
Mar 16, 2021
| @@ -164,6 +164,8 @@ func (b *listParser) Continue(node ast.Node, reader text.Reader, pc Context) Sta | |||
| if node.ChildCount() == 1 && node.LastChild().ChildCount() == 0 { | |||
| return Close | |||
| } | |||
|
|
|||
| reader.Advance(len(line)-1) | |||
There was a problem hiding this comment.
nit: A comment explaining "why" would be helpful here
There was a problem hiding this comment.
Hm I already forgot :D it would get me a while to get into this
There was a problem hiding this comment.
😆 That's why I write the "why" comments
|
thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for independent issue in #177
The next parser should have the whitespace removed, even when it's blank