Promise flaky test

[jenny]

The following test passes locally, but fails with Yeti in CI and Yeti locally. We are addressing all such flaky tests in the repo by refactoring tests, increasing timeouts, etc. Please let me know if you have any questions on how best to address this issue. Improving the test helps us have a reliable CI system. Thanks!

Firefox (19_0) / Windows XP.Promise.Promise: Y.batch: batch should fail as fast as possible

[juandopazo]

I'll set up Yeti and give it a try.

Does it happen only in Windows XP?

[juandopazo]

I'm running into an issue with Yeti when trying to test this. After starting Yeti, Firefox in Windows XP navigates to a URL like /agent/123/batch/123/test/src\promise\tests\unit\promise.html instead of /agent/123/batch/123/test/src/promise/tests/unit/promise.html.

[juandopazo]

Jenny, could I see the result of the assertions?

[derek]

Tested and works for me on Firefox (20) and XP.

Juan, the VMs that conduct the testing tend to be a little less powerful than we we use for development, so tests relying on timeouts may need a little extra time to finish. This test times out after 100ms, can it be bumped up to 300ms just to be on the safe side?

[derek]

Also, a ping to @reid for the Yeti issue.

[juandopazo]

Yeah, I want to see the assertion result to see if the test timed out or if the assertion failed. If the assertion failed it would be really weird because even if the browser clamped the minimum timeout or took longer to finish, the order of execution of that test shouldn't change. If it times out, I'll just increase the timeout.

[jenny]

Here it is:

Firefox (19_0) / Windows XP.Promise.Promise: Y.batch: batch should fail as fast as possible

[juandopazo]

I guess that means it's timing out. I'll take a look at the internals of YUI Test to see why its own timeout could be running before the others and I'll increase it.

[juandopazo]

These unit tests were rewritten.