-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[#4421] [YCQL] Disallow Unauthenticated LDAP binding + add handling f…
…or ycql_ldap_search_filter Summary: LDAP protocol has an "Unauthenticated" bind mechanism which allows successful bind with a non-empty username but empty password. As per https://datatracker.ietf.org/doc/html/rfc4513#section-6.3.1, clients and servers, both, should steer clear of this bind mechanism. For this, a check has been added to error out on empty passwords. Another fix in this diff is that the handling and tests for ycql_ldap_search_filter were missing. They have been added now. Test Plan: Jenkins: urgent ./yb_build.sh --java-test org.yb.cql.TestLDAPAuth Reviewers: dmitry, alan, mihnea Reviewed By: alan, mihnea Subscribers: yql Differential Revision: https://phabricator.dev.yugabyte.com/D13197
- Loading branch information
Showing
6 changed files
with
291 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.