[CLOUDGA-24851] Remove root node info from cluster creation #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-yb
force-pushed
the
CLOUDGA-24851
branch
from
9a76bd6
to
5ff7c2b
Compare
posriniv
approved these changes
Nov 25, 2024
| func NewAuthApiClient() (*AuthApiClient, error) { | ||
| url, err := ParseURL(viper.GetString("host")) | ||
| parseURL, err := ParseURL(viper.GetString("host")) |
There was a problem hiding this comment.
This can simply be url right?
There was a problem hiding this comment.
my IDE warns me to rename it.
daniel-yb
force-pushed
the
CLOUDGA-24851
branch
from
5ff7c2b
to
febca8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by running:
This PR depends on https://github.com/yugabyte/yugabyte-cloud/pull/18615.