Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sqlfluff v1.4.5 #52

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

vgw-chriskruger
Copy link
Contributor

The current release version of sqlfluff is 1.4.5. This PR allows for its use in the action.

@yu-iskw
Copy link
Owner

yu-iskw commented Jan 11, 2023

@vgw-chriskruger Thank you for the pull request. Can you modify any testing SQL file of a dbt model. For instance, just deleting an empty line would be ok. By doing so, the GitHub Actions to validate SQL files will work.

@vgw-chriskruger
Copy link
Contributor Author

So it looks like the checks have run now.

@yu-iskw
Copy link
Owner

yu-iskw commented Jan 12, 2023

The GitHub Action skips to execute SQLFluss, if there is no changed files. That's because SQLFluss takes a long time, if there are a lot of scanned files. So, the Action checks only changed files.

https://github.com/yu-iskw/action-sqlfluff/blob/main/entrypoint.sh#L24-L29

We take advantage of the testing dbt project in testdata/test_failed_dbt. We have to change any of SQL files to completely check changes in pull requests are ok.

https://github.com/yu-iskw/action-sqlfluff/tree/main/testdata/test_failed_dbt

As we don't have any changes of testing SQL files in the pull request, entrypoint.sh existed due to no changed files.
image

@vgw-chriskruger
Copy link
Contributor Author

vgw-chriskruger commented Jan 13, 2023

Sorry I was a numpty. I didn't commit the change as I had thought 😊 apologies for the confusion.

@yu-iskw
Copy link
Owner

yu-iskw commented Jan 13, 2023

@vgw-chriskruger No problem. Now, we can see the comments by reviewdog. Let's merge this. Thank you for the contribution!

00008fe
image

@yu-iskw yu-iskw merged commit 8bc7d5f into yu-iskw:main Jan 13, 2023
treydott pushed a commit to lachupacabra/action-sqlfluff that referenced this pull request Feb 23, 2023
* support sqlfluff v1.4.5

* neaten
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants