Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xos): adding unit tests to XOS model #3355

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RayaneB75
Copy link

@RayaneB75 RayaneB75 commented Dec 28, 2024

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Following #3125, unit tests are added for XOS switches

@RayaneB75 RayaneB75 marked this pull request as draft December 28, 2024 20:11
@RayaneB75 RayaneB75 marked this pull request as ready for review December 29, 2024 14:14
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.93%. Comparing base (c8d6123) to head (c19d550).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3355      +/-   ##
==========================================
+ Coverage   70.63%   70.93%   +0.29%     
==========================================
  Files          80       82       +2     
  Lines        3266     3327      +61     
==========================================
+ Hits         2307     2360      +53     
- Misses        959      967       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertcheramy
Copy link
Collaborator

The last commit c19d550 introduces exec mode, which does not match to xos.rb (post_login and probably pre_logout commands) and to the YAML Simulation fine (use the option -e in device2yaml.rb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants