Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New teams webhook #3335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New teams webhook #3335

wants to merge 2 commits into from

Conversation

mopi3456
Copy link

@mopi3456 mopi3456 commented Dec 4, 2024

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Modified the extra/gitdiff-msteams.sh script to:

  • Honor the 28KB size limit for Teams webhooks.
  • Include a link to our local GitHub, allowing users to view the diff in the web interface.

git teams webhook:
Shorten length if > 28kb
Updated with button that links to internal github
@systeembeheerder
Copy link
Contributor

Honor the 28KB size limit for Teams webhooks

thanx

Include a link to our local GitHub,

al least make it optional. I don't think adding github as dependency is a good thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants