Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[options] Accept quoted string across multiple lines (#9940) #9945

Closed
wants to merge 2 commits into from
Closed

[options] Accept quoted string across multiple lines (#9940) #9945

wants to merge 2 commits into from

Conversation

jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Jun 29, 2016

I think there shouldn't be any downside for passing the whole file to shlex, but if there are, please tell me.

@jaimeMF jaimeMF mentioned this pull request Jun 29, 2016
Closed
4 tasks
@yan12125
Copy link
Collaborator

Maybe better to add an multiline examples to test_compat_shlex_split().

@jaimeMF
Copy link
Collaborator Author

jaimeMF commented Jun 29, 2016

Maybe better to add an multiline examples to test_compat_shlex_split().

Added a test in 3a7e7ed.

@dstftw
Copy link
Collaborator

dstftw commented Jun 30, 2016

Cherry-picked, thanks.

@dstftw dstftw closed this Jun 30, 2016
@jaimeMF jaimeMF deleted the config-quoted-strings-multiline branch June 30, 2016 21:10
@keybounce
Copy link

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaimeMF @yan12125 @dstftw @keybounce