Fixed groups() call on potentially empty regex search object #30676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Feb 24, 2022
* https://github.com/ytdl-org/youtube-dl: [CPAC] Add extractor for Canadian Parliament Fixed groups() call on potentially empty regex search object (ytdl-org#30676) [aliexpress] Fix test case [bigo] add support for bigo.tv (ytdl-org#30635)
gaming-hacker
added a commit
to gaming-hacker/youtube-dl
that referenced
this pull request
Feb 28, 2022
* commit '6508688e88c83bb811653083db9351702cd39a6a': Make default upload_/release_date a compat_str Avoid skipping ID when unlisted_hash is numeric [Alsace20TV] Add new extractors Alsace20TVIE, Alsace20TVEmbedIE [CPAC] Add extractor for Canadian Parliament Fixed groups() call on potentially empty regex search object (ytdl-org#30676) [aliexpress] Fix test case [bigo] add support for bigo.tv (ytdl-org#30635)
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jun 27, 2022
…g#30676) * Fixed groups() call on potentially empty regex search object. - ytdl-org#30521 * minimising lines changed Co-authored-by: yayorbitgum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Within the myspass site extractor, there is a short regex for checking for certain substrings in the video url.
groups()was called onre.search()without first ensuring there were any results to return a regex object. I've added a simple check for this.Resolves #30521
Closes #30522