Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BitChutePlaylist] Add new extractor #26725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BitChutePlaylist] Add new extractor #26725

wants to merge 1 commit into from

Conversation

sidneys
Copy link

@sidneys sidneys commented Sep 27, 2020

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This pull request adds the BitChutePlaylistextractor, introducing playlist download support for BitChute.

@ghost
Copy link

ghost commented Aug 30, 2021

Your PR seems to need a fix to eliminate duplicate entries.

With this playlist https://www.bitchute.com/playlist/9UsDwfa6PzoQ/, 22 videos are extracted, whereas it actually contains 19 videos.
In the output below, last 3 entries are duplicated:

$ python -m youtube_dl https://www.bitchute.com/playlist/9UsDwfa6PzoQ/ --flat-playlist -j
{"url": "https://www.bitchute.com/video/Mil3YhjHEL8Z", "_type": "url", "ie_key": "BitChute", "id": "Mil3YhjHEL8Z"}
{"url": "https://www.bitchute.com/video/FeWkrZGVZovZ", "_type": "url", "ie_key": "BitChute", "id": "FeWkrZGVZovZ"}
{"url": "https://www.bitchute.com/video/BJkbSBOcopou", "_type": "url", "ie_key": "BitChute", "id": "BJkbSBOcopou"}
{"url": "https://www.bitchute.com/video/IdbWp32BZoTC", "_type": "url", "ie_key": "BitChute", "id": "IdbWp32BZoTC"}
{"url": "https://www.bitchute.com/video/rKM7Mo3myFGc", "_type": "url", "ie_key": "BitChute", "id": "rKM7Mo3myFGc"}
{"url": "https://www.bitchute.com/video/kcMmN8ejkY8s", "_type": "url", "ie_key": "BitChute", "id": "kcMmN8ejkY8s"}
{"url": "https://www.bitchute.com/video/tTXG8cNnQoA", "_type": "url", "ie_key": "BitChute", "id": "tTXG8cNnQoA"}
{"url": "https://www.bitchute.com/video/_4sH9cki1KQ", "_type": "url", "ie_key": "BitChute", "id": "_4sH9cki1KQ"}
{"url": "https://www.bitchute.com/video/f6Y8dt_Mmqw", "_type": "url", "ie_key": "BitChute", "id": "f6Y8dt_Mmqw"}
{"url": "https://www.bitchute.com/video/oMTZwAZVwGQ", "_type": "url", "ie_key": "BitChute", "id": "oMTZwAZVwGQ"}
{"url": "https://www.bitchute.com/video/zmtjJ2rC5gmS", "_type": "url", "ie_key": "BitChute", "id": "zmtjJ2rC5gmS"}
{"url": "https://www.bitchute.com/video/4doTXt_Ink8", "_type": "url", "ie_key": "BitChute", "id": "4doTXt_Ink8"}
{"url": "https://www.bitchute.com/video/HXT4EqJIzaM", "_type": "url", "ie_key": "BitChute", "id": "HXT4EqJIzaM"}
{"url": "https://www.bitchute.com/video/_-rpR7M9pEM", "_type": "url", "ie_key": "BitChute", "id": "_-rpR7M9pEM"}
{"url": "https://www.bitchute.com/video/agZRBKWvO1g", "_type": "url", "ie_key": "BitChute", "id": "agZRBKWvO1g"}
{"url": "https://www.bitchute.com/video/WVDFj9MutYo", "_type": "url", "ie_key": "BitChute", "id": "WVDFj9MutYo"}
{"url": "https://www.bitchute.com/video/aCuSC19Lxjtr", "_type": "url", "ie_key": "BitChute", "id": "aCuSC19Lxjtr"}
{"url": "https://www.bitchute.com/video/plRpBpwBE7hi", "_type": "url", "ie_key": "BitChute", "id": "plRpBpwBE7hi"}
{"url": "https://www.bitchute.com/video/wt6MCBkwMKzj", "_type": "url", "ie_key": "BitChute", "id": "wt6MCBkwMKzj"}
{"url": "https://www.bitchute.com/video/plRpBpwBE7hi", "_type": "url", "ie_key": "BitChute", "id": "plRpBpwBE7hi"}
{"url": "https://www.bitchute.com/video/wt6MCBkwMKzj", "_type": "url", "ie_key": "BitChute", "id": "wt6MCBkwMKzj"}
{"url": "https://www.bitchute.com/video/wt6MCBkwMKzj", "_type": "url", "ie_key": "BitChute", "id": "wt6MCBkwMKzj"}

@ghost ghost mentioned this pull request Aug 30, 2021
5 tasks
@Cyberes
Copy link

Cyberes commented Sep 25, 2021

I'm not seeing any duplicates in my tests. I piped kikuyan's command to uniq --count and there weren't any duplicates.

@ghost
Copy link

ghost commented Sep 25, 2021

I tried again with 2021.06.06 plus this PR, git master plus this PR, and got the same results as before. Strange.

dirkf added a commit to dirkf/youtube-dl that referenced this pull request Jun 10, 2022
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Jun 10, 2022
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Jun 10, 2022
gaming-hacker added a commit to gaming-hacker/youtube-dl that referenced this pull request Jun 12, 2022
* commit 'add5e7dced00484343692dc04d568bc6b46ceeb3':
  [BitChute] Extract `channel_url` * resolves ytdl-org#28500
  [BitChute] Handle NSFW in listings and single videos * listing: include NSFW if --age-limit 18 (or higher) * single video: extract 'age_limit': 18 if NSFW Resolves ytdl-org#24419
  [BitChute] Added BitChutePlaylistIE * closes ytdl-org#26725
  [BitChute] Back-port from yt-dlp and upgrade BitChute * extract timestamp instead of upload date * improve title and description extraction BitChuteChannel * fix listing entries Throughout * relax regexes
  [HRFernsehen] Back-port new extractor from yt-dlp Closes ytdl-org#26445, where this was originally proposed.
  [utils] Escape URL while sanitizing Closes ytdl-org#31008, #yt-dlp/263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants