Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some problems with BYU TV #14967

Closed
wants to merge 1 commit into from
Closed

Fix some problems with BYU TV #14967

wants to merge 1 commit into from

Conversation

micahfocht
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [x ] I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • [ x] Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
Ok, a bit of a beginner here. I ran into an issue when trying to download an episode of Studio C from BYU TV. Basically, any links from the site aren't recognized as valid links. This is a reasonably large problem, but it was also fairly easy to solve. Essentially, in the URL, they changed watch to player. So I changed that, and links were recognized again. That's progress. But, it still spits out the error "ERROR: Unable to extract episode information" I've narrowed this down to line 38 I believe. I don't really know how to fix this error, since it seems to be calling another function within common.py at line 2581. I don't really have the expertise to diagnose this any further. Hopefully someone else will see this and know what to do. I'm committing this because regardless of the fact that an error still exists, this fixes one. I would spend more time on this, but it's nearing 1 am and I have a feeling I'll forget what I was doing when I wake up. I'll create a issue and reference this pull request as well. Thanks for the help, Micah.

Ok, a bit of a beginner here.  I ran into an issue when trying to download an episode of Studio C from BYU TV.  Basically, any links from the site aren't recognized as valid links.  This is a reasonably large problem, but it was also fairly easy to solve.  Essentially, in the URL, they changed watch to player.  So I changed that, and links were recognized again.  That's progress.  But, it still spits out the error "ERROR: Unable to extract episode information"  I've narrowed this down to line 38 I believe.  I don't really know how to fix this error, since it seems to be calling another function within common.py at line 2581.  I don't really have the expertise to diagnose this any further.  Hopefully someone else will see this and know what to do.  I'm committing this because regardless of the fact that an error still exists, this fixes one.  I would spend more time on this, but it's nearing 1 am and I have a feeling I'll forget what I was doing when I wake up.  I'll create a issue and reference this pull request as well.  Thanks for the help, Micah.
@micahfocht micahfocht mentioned this pull request Dec 13, 2017
4 tasks
@dstftw dstftw closed this in c8be7d5 Dec 13, 2017
PuffingtonToast referenced this pull request in PuffingtonToast/youtube-dl Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant