-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VoxMedia (The Verge) Broken #28338
Comments
My fix to this would be replacing line 29 to line 36 with: formats = []
hls_url = setup.get('hls_url')
if hls_url:
formats.extend(self._extract_m3u8_formats(
hls_url, video_id, 'mp4', 'm3u8_native', m3u8_id='hls', fatal=False))
mp4_url = setup.get('mp4_url') But I can't do the |
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this issue
Mar 4, 2021
* https://github.com/ytdl-org/youtube-dl: [trovo] Add Origin header to VOD formats(closes ytdl-org#28346) [voxmedia] fix volume embed extraction(closes ytdl-org#28338)
leshasmlesha
pushed a commit
to leshasmlesha/youtube-dl
that referenced
this issue
Mar 7, 2021
leshasmlesha
pushed a commit
to leshasmlesha/youtube-dl
that referenced
this issue
Mar 7, 2021
This was referenced Mar 15, 2021
leshasmlesha
pushed a commit
to leshasmlesha/youtube-dl
that referenced
this issue
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Verbose log
Description
From
view-source:https://volume.vox-cdn.com/embed/b624f2415
, I can find the target m3u8 link in:I'm not familiar with many functions/methods used in the voxmedia.py, but I found:
it didn't try to find
hls_url
ormp4_url
inside theembed_assets
orchorus
object,because it only tried to find it in
asset
orparams
object.AND It can just try to find the url in the whole
setup
object.<meta name="twitter:player:stream" content="hls_url">
is not supported yet, I think this m3u8 file url source may last longer than the js objects.The text was updated successfully, but these errors were encountered: