-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Use backport service #3553
Comments
I'm 100% favourable to this. |
That sounds like a really good idea with a much smaller chance of human error! Just don't allow meeseeks to pop meeseeks. |
Can we change branches that it issues PRs to? We modified our backporting process last release cycle so bugfixes will be on a |
Yes, we can -- it gets the info from the description of the label applied to the PR. |
excellent, this is exactly how matplotlib sets it up too |
In favor. |
Note that as noted in #3555, back porting is safer if we manage to reproduce the merging of the original PRs |
I think we should try it by seeing if labeling a closed PR will result in
it backporting. Which one do you think is the safest?
…On Fri, Oct 15, 2021 at 3:11 AM Clément Robert ***@***.***> wrote:
Note that as noted in #3555 <#3555>,
back porting is safer if we manage to reproduce the merging of the original
PRs
With this is mind, we should probably hold on deploying Mr Meeseesks as
long as we're not done manually back porting the list from #3555
<#3555>, *except* if Mr Meeseeks
can somehow be utilized to do it for us ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3553 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXO6WDJEHXZ3SS3DMENLUG7OZTANCNFSM5FZNT5BA>
.
|
#3238, which happens to be at the top of the list, has 0 potential conflict with anything else, I believe :) |
OK, sounds good. I'm going to install and we can try it out on that one.
…On Fri, Oct 15, 2021 at 9:23 AM Clément Robert ***@***.***> wrote:
#3238 <#3238>, which happens to be
at the top of the list, has 0 potential conflict with anything else, I
believe :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3553 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXO5GCKGXQORTV4OCZO3UHA2NBANCNFSM5FZNT5BA>
.
|
Applying labels to closed PRs won't work. But, we can add to our mergable status that there has to be a label of "backport*" or "dont-backport" which would get us doing it regularly. |
PRs that need manual backports will be labeled, but, closed: Still Needs Manual Backport |
So we've been using this tool to semi-manually backport a couple dozens PRs in these last few weeks. I guess the question that needs answering now is whether we'd like to switch to a continuous backporting workflow (which is also supported by meeseeksbox). It would basically have a similar cost in terms of activity (one backport per PR), but it would offer the following advantages:
I would personally be favourable to this kind of workflow, as I think the gain outweighs the costs. |
Continuous backporting was (sort of) rejected last time it was mentioned on the mailing list, and it looks like we're not doing a third bugfix release on the current backport branch after yt 4.0.2 |
At present, backporting PRs from
main
tostable
is a manual process that requires considerable investment. This typically results in a large, labor-intensive effort to make a bugfix release.I would like to propose that we install meeseeksbox, which is an automated system for backporting PRs. What we would do is install it, and then any PR to which the label
backport
is applied would catch its attention, and when it is merged, it would also be applied to thestable
branch (in a new PR). When a conflict is detected, it does not go through, and gets flagged for attention.Among other things, this also means we could bulk label things for backporting, and it would help us to keep a stable branch that was up to date and in a state of ready-to-release.
The text was updated successfully, but these errors were encountered: