Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify socketio implementation #182

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Simplify socketio implementation #182

merged 6 commits into from
Oct 18, 2024

Conversation

archessmn
Copy link
Member

No description provided.

markspolakovs
markspolakovs requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@markspolakovs markspolakovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and is a good change, but you could make it even better.

app/(authenticated)/calendar/[eventID]/signUpSheetActions.ts Outdated Show resolved Hide resolved
app/(authenticated)/user/me/actions.ts Outdated Show resolved Hide resolved
docs/development/implementing_socket_io.md Outdated Show resolved Hide resolved
docs/development/implementing_socket_io.md Outdated Show resolved Hide resolved
lib/socket/server/user.ts Outdated Show resolved Hide resolved
markspolakovs
markspolakovs approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@markspolakovs markspolakovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shit boss

docs/development/implementing_socket_io.md Outdated Show resolved Hide resolved
@jenkins-ystv
Copy link

jenkins-ystv bot commented Oct 18, 2024

Deployed a preview of this PR to https://pr-182-internal.dev.ystv.co.uk

@archessmn archessmn merged commit c48b4b8 into main Oct 18, 2024
1 of 3 checks passed
@archessmn archessmn deleted the mia/socket-fuckery branch October 18, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markspolakovs markspolakovs markspolakovs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archessmn @markspolakovs