-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves footer into nav to fix main body size issues #141
base: main
Are you sure you want to change the base?
Conversation
Not ready to merge: Just realised I removed the feedback prompt |
Okay now the feedback prompts there, future note, maybe we could cut down on how much we're putting in the footer? it's getting quite wordy and is starting to look a little bloated on mobile imo |
Deployed a preview of this PR to https://pr-141-internal.dev.ystv.co.uk |
Some thoughts:
As you said, it just seems too much on mobile. I think quite a bit of the navigation / layout needs some tweaking as aside from the profile dropdown, I don't think it's really been changed since the very early builds. |
Definitely agree, thinking I might take this PR back to the drawing board a bit and turn it into a bit more of a general 🫡 navigational overhaul |
Actually thinking on it a little more, will probably fold this in with the homepage as most of the info in the footer could probably be moved there too |
That makes sense, one thing we really need is a proper nav menu now that we're adding more pages at the root, I may have a look at doing that tomorrow unless you're wanting to do that as part of this? |
Will probably look into it as part of this |
Moves footer into nav to fix main body size issues, which could potentially cause header to cover content