Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves footer into nav to fix main body size issues #141

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Keeeeeeeen
Copy link
Contributor

Moves footer into nav to fix main body size issues, which could potentially cause header to cover content

@Keeeeeeeen
Copy link
Contributor Author

Not ready to merge: Just realised I removed the feedback prompt

@Keeeeeeeen
Copy link
Contributor Author

Okay now the feedback prompts there, future note, maybe we could cut down on how much we're putting in the footer? it's getting quite wordy and is starting to look a little bloated on mobile imo

@jenkins-ystv
Copy link

jenkins-ystv bot commented Sep 4, 2024

Deployed a preview of this PR to https://pr-141-internal.dev.ystv.co.uk

@archessmn
Copy link
Member

archessmn commented Sep 5, 2024

Some thoughts:
I do wonder how necessary the footer actually is with the current usage:

  • Version is only really something that people doing development need to know.
  • Built and maintained by the computing team isn't something that really needs to be advertised to the people who are using it, seeing as they're almost all exclusively YSTV members who are aware comp team made it.
  • Feedback is the only thing that really needs to be available to the average user, but even then that could just be put in the user menu dropdown.

As you said, it just seems too much on mobile. I think quite a bit of the navigation / layout needs some tweaking as aside from the profile dropdown, I don't think it's really been changed since the very early builds.

@Keeeeeeeen
Copy link
Contributor Author

Definitely agree, thinking I might take this PR back to the drawing board a bit and turn it into a bit more of a general 🫡 navigational overhaul

@Keeeeeeeen
Copy link
Contributor Author

Actually thinking on it a little more, will probably fold this in with the homepage as most of the info in the footer could probably be moved there too

@archessmn
Copy link
Member

That makes sense, one thing we really need is a proper nav menu now that we're adding more pages at the root, I may have a look at doing that tomorrow unless you're wanting to do that as part of this?

@Keeeeeeeen
Copy link
Contributor Author

Will probably look into it as part of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants