-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INT-141] [INT-142] User and role management #137
Conversation
Management page for: - Users - Roles - Individual User A couple other things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Not done a fully exhaustive review, these are just the first things I spotted.
app/(authenticated)/(superuser)/admin/users/[userID]/GiveUserRoleForm.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Marks Polakovs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we as a codebase need to decide where action permissions checks go - the action function or the feature? My preference is for the former as it's easier to tell what permission an action needs.
Otherwise looking good, mainly just error handling.
Co-authored-by: Marks Polakovs <[email protected]>
Co-authored-by: Marks Polakovs <[email protected]>
Co-authored-by: Marks Polakovs <[email protected]>
Having the permissions checks in the features makes sure that checks aren't forgotten when implementing those features in the future, some features are also passed directly from server components without an action wrapper and so the checks are required in the feature. |
Deployed a preview of this PR to https://pr-137-internal.dev.ystv.co.uk |
Requested changes have been made
Add admin pages for managing users and roles.
Features: