Fix login logic and signout button #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed a preview of this PR to https://pr-136-internal.dev.ystv.co.uk |
markspolakovs
approved these changes
Sep 2, 2024
| @@ -21,7 +21,7 @@ export default function Nav({ children, user }: NavProps) { | |||
| padding="md" | |||
| classNames={{ header: styles.header }} | |||
| > | |||
| <AppShell.Header bg-dark> | |||
| <AppShell.Header bg-dark="true"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google login and signing out in dev is currently broken, this should fix that. Google complained about the login_uri containing the redirect search parameter and so instead we use a cookie to store the redirect instead. Signing out would attempt to delete a cookie that was on the wrong domain, as it was not using
env.COOKIE_DOMAINwhich is used in dev.