Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation part 3: per-window animations #1303

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Animation part 3: per-window animations #1303

merged 4 commits into from
Aug 5, 2024

Conversation

yshui
Copy link
Owner

@yshui yshui commented Aug 4, 2024

Use it like this:

rules = ({
    match = "...";
    animations = ({
        triggers = ["open"];
        # animation script
    });
});

Leave the script empty to disable animation for that trigger.

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.86%. Comparing base (567c0ba) to head (4777327).

Files Patch % Lines
src/config_libconfig.c 88.88% 1 Missing ⚠️
src/wm/win.h 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1303   +/-   ##
=======================================
  Coverage   52.85%   52.86%           
=======================================
  Files          64       64           
  Lines       14011    14020    +9     
=======================================
+ Hits         7406     7411    +5     
- Misses       6605     6609    +4     
Files Coverage Δ
src/config.h 30.00% <100.00%> (ø)
src/picom.c 64.60% <100.00%> (-0.11%) ⬇️
src/wm/win.c 78.13% <100.00%> (ø)
src/config_libconfig.c 57.31% <88.88%> (+0.04%) ⬆️
src/wm/win.h 92.85% <66.66%> (-1.18%) ⬇️

... and 1 file with indirect coverage changes

Default value for when nothing is set, was wrong.

Signed-off-by: Yuxuan Shui <[email protected]>
Should be "unredir", accidentally used the old name.

Signed-off-by: Yuxuan Shui <[email protected]>
@yshui yshui changed the title Animation rules Animation part 3: per-window animations Aug 5, 2024
@yshui yshui merged commit 0efe479 into next Aug 5, 2024
22 checks passed
@yshui yshui deleted the animation-rules branch August 5, 2024 18:19
@pijulius
Copy link
Contributor

pijulius commented Aug 5, 2024

This looks/works great, thank you so much! now we can go crazy with any animation for any kind of window :)

@absolutelynothelix absolutelynothelix mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants