Skip to content
This repository has been archived by the owner on Oct 2, 2018. It is now read-only.

Add sorting algorithms #21

Open
yshshrm opened this issue Oct 19, 2017 · 8 comments
Open

Add sorting algorithms #21

yshshrm opened this issue Oct 19, 2017 · 8 comments

Comments

@yshshrm
Copy link
Owner

yshshrm commented Oct 19, 2017

Contributing Guidelines

  • The repository is structured language-wise i.e. algorithms in a certain language go in a specific folder.
  • The naming convention to be followed is algo_name.language_extention i.e. the overall path should be language/algo_name.language_extention
  • It is your choice to include only the function or the entire program for the algorithm.
  • If the folder for your language does not exist, create a new one.
  • Don't be afraid to make a PR!

How to make PR

  1. Fork Repo on Web Page
  2. Make your changes on your forked repo
  3. Make Pull Request to master
@cgarciahdez
Copy link

Hi @kvaluruk ! Is there any specific sorting algorithm that you would like added? Some of the more inefficient ones are easier to understand for beginners, but I think having the more advanced ones is also important. If you want different sorting algorithms, would they ideally be in separate files or the same file?

@carewdavid
Copy link
Contributor

I can help out with that!

@PiSolve
Copy link
Contributor

PiSolve commented Oct 20, 2017

Hi @kvaluruk , I would like to add all basic sorting algorithms for java (bubble , insertion , selection , quicksort , merge sort).

@yshshrm
Copy link
Owner Author

yshshrm commented Oct 20, 2017

@cgarciahdez There isn't any specific list of sorting algorithms to be added. This is a project for beginners to get started with open-source (and build an algorithm directory in the meanwhile), so any type of algorithms would be welcome.
As for sorting algorithms, I'd prefer them to be in the same file, although there isn't any compulsion. Thanks for asking!

@rahmatrasyidi
Copy link
Contributor

Hi @kvaluruk I would like to add search algorithm for java like binary search and linear search.

@antrix190
Copy link
Contributor

Hi @kvaluruk I added Java implementation of heap sort and created a PR.

@jpdilan
Copy link
Contributor

jpdilan commented Oct 25, 2017

It's better if you can implement different folders like "Sorting_algorithms" and "Data_structures" for each language , it will be easy to contributors also users of this repo :)

@yshshrm
Copy link
Owner Author

yshshrm commented Oct 25, 2017

@jpdilan Agreed. I've created an issue for the same.

yshshrm pushed a commit that referenced this issue Oct 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants