Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot connect after previous connection failure #154

Open
mathieumallet opened this issue Mar 20, 2019 · 5 comments
Open

Cannot connect after previous connection failure #154

mathieumallet opened this issue Mar 20, 2019 · 5 comments
Assignees
Labels
bug core Issues related to easy_profiler_core resolved ui Issues related to profiler_gui

Comments

@mathieumallet
Copy link

mathieumallet commented Mar 20, 2019

Steps to reproduce:

  1. Run profiler_gui
  2. Attempt to connect to a non-running application -- the 'Cannot connect' dialog is shown
  3. Run the application to be profiled
  4. Attempt to connect -- the 'Cannot connect' dialog is shown again

Restarting profiler_gui is required to workaround the problem.

@rationalcoder
Copy link
Contributor

I always thought my custom build of the core was broken and profiling would crash my application or something. If this is just a problem in the GUI, that's really good news!

@mathieumallet
Copy link
Author

Well it's also possible that both our custom builds are broken in the same way ;)

@cas4ey cas4ey added bug core Issues related to easy_profiler_core ui Issues related to profiler_gui labels Mar 25, 2019
@cas4ey
Copy link
Collaborator

cas4ey commented Mar 25, 2019

@yse can you please check and fix it?

yse added a commit that referenced this issue Mar 26, 2019
@yse
Copy link
Owner

yse commented Mar 26, 2019

I've check fix on linux and macos. Problem was related to unclosed socket on connection failure. Can anybody check it on windows? But I think it's fixed also on windows

@cas4ey
Copy link
Collaborator

cas4ey commented Mar 28, 2019

Checked on windows - it works.

@cas4ey cas4ey added this to the Release v2.1.0 milestone Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core Issues related to easy_profiler_core resolved ui Issues related to profiler_gui
Projects
None yet
Development

No branches or pull requests

4 participants