Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nibe S1156 #198

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Nibe S1156 #198

merged 2 commits into from
Jan 5, 2025

Conversation

hajekmi
Copy link
Contributor

@hajekmi hajekmi commented Jan 3, 2025

No description provided.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (34541b6) to head (2a41278).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   70.13%   70.15%   +0.02%     
==========================================
  Files          14       14              
  Lines        1356     1357       +1     
==========================================
+ Hits          951      952       +1     
  Misses        405      405              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yozik04
Copy link
Owner

yozik04 commented Jan 4, 2025

I am thinking if it is similar to S1256? At the moment we have S1155 and S1255 merged into one file: s1155_s1255. I think we need to do the same for S1156 and S1256.

@yozik04
Copy link
Owner

yozik04 commented Jan 4, 2025

With this PR current S1256 HA setups will have less registers. It used s1155_s1255 before and new separate CSV has less registers defined.

@hajekmi
Copy link
Contributor Author

hajekmi commented Jan 4, 2025

I agree that S1156 and S1256 will have similar registers. The only difference is the integrated tray, but the temperature sensors will be the same.
Thanks

@yozik04 yozik04 merged commit 7ce671c into yozik04:master Jan 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants