Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up construct configuration for nibe gw #179

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

elupus
Copy link
Collaborator

@elupus elupus commented Oct 12, 2024

This reduces the nesting depth and make the logged output from a parsed block more readable.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.65%. Comparing base (5c1eba7) to head (2195a07).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
nibe/console_scripts/cli.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   57.84%   58.65%   +0.80%     
==========================================
  Files          14       14              
  Lines        1274     1289      +15     
==========================================
+ Hits          737      756      +19     
+ Misses        537      533       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yozik04 yozik04 merged commit 9431e9a into yozik04:master Oct 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants