Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle out of range values on rmu data #173

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

elupus
Copy link
Collaborator

@elupus elupus commented Aug 24, 2024

We need to apply the same out of range checks for RMU data, since these fields also send out range data on error values.

Swapping scale and offset and applying same range checks for RMU data.

Swapping scale and offset and applying same range checks
for RMU data.
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.84%. Comparing base (7943537) to head (e36130c).
Report is 6 commits behind head on master.

Files Patch % Lines
nibe/connection/nibegw.py 70.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   57.69%   57.84%   +0.15%     
==========================================
  Files          14       14              
  Lines        1267     1274       +7     
==========================================
+ Hits          731      737       +6     
- Misses        536      537       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elupus
Copy link
Collaborator Author

elupus commented Aug 24, 2024

Ps. I'm starting to think there are no 2's complement signed values anywhere in the pump. All are unsigned values with some defined offset to make them signed.

@yozik04
Copy link
Owner

yozik04 commented Aug 24, 2024

Would be great to add some test coverage on these changes.

@elupus
Copy link
Collaborator Author

elupus commented Aug 25, 2024

Don't seem to be able to hit the error values with the FixedPointStrange, since with positive offsets we can never hit the limit values. I've not seen any error values on the outdoor temp field so far. In theory it could indicate errors with the unused values in the gap i suppose (ie a zero value). I've removed that check for now.

@yozik04 yozik04 merged commit 5c1eba7 into yozik04:master Aug 26, 2024
8 checks passed
@yozik04
Copy link
Owner

yozik04 commented Aug 26, 2024

Great, thank you. Merged. Do you need a new release?

@elupus elupus deleted the rmu_out_of_range branch August 26, 2024 05:00
@elupus
Copy link
Collaborator Author

elupus commented Aug 26, 2024

Can hold of a bit. Got a weird 32 bit degree minutes parameter issue since the myuplink upgrade that need to be looked at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants