-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle out of range values on rmu data #173
Conversation
Swapping scale and offset and applying same range checks for RMU data.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
==========================================
+ Coverage 57.69% 57.84% +0.15%
==========================================
Files 14 14
Lines 1267 1274 +7
==========================================
+ Hits 731 737 +6
- Misses 536 537 +1 ☔ View full report in Codecov by Sentry. |
Ps. I'm starting to think there are no 2's complement signed values anywhere in the pump. All are unsigned values with some defined offset to make them signed. |
Would be great to add some test coverage on these changes. |
Don't seem to be able to hit the error values with the FixedPointStrange, since with positive offsets we can never hit the limit values. I've not seen any error values on the outdoor temp field so far. In theory it could indicate errors with the unused values in the gap i suppose (ie a zero value). I've removed that check for now. |
Great, thank you. Merged. Do you need a new release? |
Can hold of a bit. Got a weird 32 bit degree minutes parameter issue since the myuplink upgrade that need to be looked at. |
We need to apply the same out of range checks for RMU data, since these fields also send out range data on error values.
Swapping scale and offset and applying same range checks for RMU data.