Merging S1156 with S1256 (has now less registers because of that)

yozik04 · Jan 4, 2025 · 2a41278 · 2a41278
1 parent 6509a25
commit 2a41278
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/nibe/data/s1156.csv → nibe/data/s1156_s1256.csv b/nibe/data/s1156.csv → nibe/data/s1156_s1256.csv
@@ -1,4 +1,4 @@
-Title	Register type	Register	Division factor	Unit	Size of variable	Min value	Max value	Default value	
+Title	Register type	Register	Division factor	Unit	Size of variable	Min value	Max value	Default value
 Current outdoor temperature (BT1)	MODBUS_INPUT_REGISTER	1	10	°C	2	0	0	0
 Supply line (EP23-BT2)	MODBUS_INPUT_REGISTER	2	10	°C	2	0	0	0
 Supply line (EP22-BT2)	MODBUS_INPUT_REGISTER	3	10	°C	2	0	0	0

diff --git a/nibe/data/s1156.json → nibe/data/s1156_s1256.json b/nibe/data/s1156.json → nibe/data/s1156_s1256.json
diff --git a/nibe/heatpump.py b/nibe/heatpump.py
@@ -31,7 +31,8 @@ class Model(Enum):
     S1155 = "s1155_s1255", Series.S
     S1255 = "s1155_s1255", Series.S
 
-    S1256 = "s1155_s1255", Series.S
+    S1156 = "s1156_s1256", Series.S
+    S1256 = "s1156_s1256", Series.S
 
     F1145 = "f1145_f1245", Series.F
     F1245 = "f1145_f1245", Series.F

diff --git a/tests/test_heatpump.py b/tests/test_heatpump.py
@@ -89,11 +89,14 @@ async def test_initalization_failed(self):
     "model,series",
     [
         (Model.F370, Series.F),
+        (Model.F470, Series.F),
         (Model.F730, Series.F),
+        (Model.F750, Series.F),
         (Model.F1145, Series.F),
         (Model.F1245, Series.F),
         (Model.F1155, Series.F),
         (Model.F1255, Series.F),
+        (Model.F1345, Series.F),
         (Model.F1355, Series.F),
         (Model.SMO20, Series.F),
         (Model.SMO40, Series.F),
@@ -108,7 +111,9 @@ async def test_initalization_failed(self):
         (Model.S735, Series.S),
         (Model.S1155, Series.S),
         (Model.S1255, Series.S),
+        (Model.S1156, Series.S),
         (Model.S1256, Series.S),
+        (Model.S2125, Series.S),
     ],
 )
 def test_series(model: Model, series: Series):