Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make typing_extensions a hard dependency #319

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Oct 24, 2024

It's used in

from typing_extensions import TypeIs

I updated conda-forge/mypy_boto3_builder-feedstock#132 to reflect the dependencies here, and now it's failing.

Notes

Please describe your changes here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

All of these are optional:

  • I have performed a self-review of my own code
  • I have run ./scripts/before_commit.sh to follow the style guidelines of this project
  • I have tested my code changes

Thank you!

@vemel vemel merged commit 3b449fc into youtype:main Oct 25, 2024
@vemel
Copy link
Collaborator

vemel commented Oct 25, 2024

Hello!

Thank you for your contribution. I gladly accept it. I think for now I can use TypeGuard instead of TypeIs until the project is migrated to 3.13.

@maresb maresb deleted the patch-1 branch October 25, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants