-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the Starboard message pump. #4772
Conversation
1b2f115
to
47c478c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Mostly LGTM with minor nits.
Would love to avoid touching as much non-Cobalt code but I understand it's pretty much impossible to not diverge at least a bit.
ff00a11
to
04e1888
Compare
components/viz/service/main/viz_compositor_thread_runner_impl.cc
Outdated
Show resolved
Hide resolved
04e1888
to
488582d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but will let someone with more experience give it a +1 as well.
Excited to finally have events!
b8d5e20
to
8191109
Compare
1f8c612
to
951b225
Compare
The setup is similar to ATV/iOS where the existing platform main thread is re-used and the UI message pump just attaches to it. b/392620765 b/391414243
951b225
to
650ad91
Compare
The setup is similar to ATV/iOS where the existing platform main thread is re-used and the UI message pump just attaches to it.
b/392620765
b/391414243