Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Starboard message pump. #4772

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

y4vor
Copy link
Contributor

@y4vor y4vor commented Jan 27, 2025

The setup is similar to ATV/iOS where the existing platform main thread is re-used and the UI message pump just attaches to it.

b/392620765
b/391414243

Copy link
Contributor

@TyHolc TyHolc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Mostly LGTM with minor nits.

Would love to avoid touching as much non-Cobalt code but I understand it's pretty much impossible to not diverge at least a bit.

base/run_loop.h Outdated Show resolved Hide resolved
base/task/sequence_manager/sequence_manager_impl.cc Outdated Show resolved Hide resolved
content/browser/browser_main_loop.cc Outdated Show resolved Hide resolved
content/shell/browser/shell.cc Outdated Show resolved Hide resolved
@y4vor y4vor force-pushed the sb_message_pump branch 4 times, most recently from ff00a11 to 04e1888 Compare January 28, 2025 03:26
base/BUILD.gn Outdated Show resolved Hide resolved
base/message_loop/message_pump.cc Outdated Show resolved Hide resolved
cobalt/cobalt.cc Show resolved Hide resolved
content/app/content_main_runner_impl.cc Show resolved Hide resolved
content/browser/browser_main_loop.cc Outdated Show resolved Hide resolved
content/shell/browser/shell.cc Show resolved Hide resolved
content/zygote/zygote_main_linux.cc Show resolved Hide resolved
@y4vor y4vor requested a review from jellefoks January 28, 2025 16:57
Copy link
Contributor

@madhurajayaraman madhurajayaraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will let someone with more experience give it a +1 as well.

Excited to finally have events!

@y4vor y4vor force-pushed the sb_message_pump branch 3 times, most recently from b8d5e20 to 8191109 Compare January 29, 2025 22:34
cobalt/BUILD.gn Outdated Show resolved Hide resolved
@y4vor y4vor force-pushed the sb_message_pump branch 9 times, most recently from 1f8c612 to 951b225 Compare February 1, 2025 17:58
The setup is similar to ATV/iOS where the existing
platform main thread is re-used and the UI message pump just
attaches to it.

b/392620765
b/391414243
@y4vor y4vor merged commit aa99278 into youtube:main Feb 1, 2025
96 of 97 checks passed
base/test/test_support_starboard.cc Show resolved Hide resolved
base/test/test_support_starboard.h Show resolved Hide resolved
build/config/ozone.gni Show resolved Hide resolved
ui/ozone/platform/starboard/BUILD.gn Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants