-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XB1] Add device lost handling #4628
Open
alexanderbobrovnik
wants to merge
1
commit into
youtube:24.lts.1+
Choose a base branch
from
alexanderbobrovnik:24lts-exp
base: 24.lts.1+
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
// Copyright 2025 The Cobalt Authors. All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#ifndef STARBOARD_EXTENSION_EGL_CONTEXT_LOST_HANDLER_H_ | ||
#define STARBOARD_EXTENSION_EGL_CONTEXT_LOST_HANDLER_H_ | ||
|
||
#include <stdint.h> | ||
|
||
#ifdef __cplusplus | ||
extern "C" { | ||
#endif | ||
|
||
#define kCobaltExtensionEglContextLostHandlerName \ | ||
"dev.cobalt.extension.EglContextLostHandler" | ||
|
||
typedef struct CobaltExtensionEglContextLostHandlerApi { | ||
// Name should be the string |kCobaltExtensionEglContextLostHandlerName|. | ||
// This helps to validate that the extension API is correct. | ||
const char* name; | ||
|
||
// This specifies the version of the API that is implemented. | ||
uint32_t version; | ||
|
||
// The fields below this point were added in version 1 or later. | ||
|
||
// Called when EGL_CONTEXT_LOST error is detected. | ||
void (*HandleEglContextLost)(); | ||
|
||
} CobaltExtensionEglContextLostHandlerApi; | ||
|
||
#ifdef __cplusplus | ||
} // extern "C" | ||
#endif | ||
|
||
#endif // STARBOARD_EXTENSION_EGL_CONTEXT_LOST_HANDLER_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// Copyright 2025 The Cobalt Authors. All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include "starboard/xb1/shared/egl_context_lost_handler.h" | ||
|
||
#include "starboard/extension/egl_context_lost_handler.h" | ||
#include "starboard/shared/starboard/media/mime_supportability_cache.h" | ||
#include "starboard/shared/uwp/application_uwp.h" | ||
|
||
using starboard::shared::starboard::media::MimeSupportabilityCache; | ||
using starboard::shared::uwp::ApplicationUwp; | ||
|
||
namespace starboard { | ||
namespace xb1 { | ||
namespace shared { | ||
|
||
namespace { | ||
|
||
void HandleEglContextLost() { | ||
MimeSupportabilityCache::GetInstance()->ClearCachedMimeSupportabilities(); | ||
ApplicationUwp::Get()->Inject( | ||
new ApplicationUwp::Event(kSbEventTypeBlur, NULL, NULL)); | ||
ApplicationUwp::Get()->Inject( | ||
new ApplicationUwp::Event(kSbEventTypeConceal, NULL, NULL)); | ||
ApplicationUwp::Get()->Inject( | ||
new ApplicationUwp::Event(kSbEventTypeFreeze, NULL, NULL)); | ||
|
||
ApplicationUwp::Get()->Inject( | ||
new ApplicationUwp::Event(kSbEventTypeUnfreeze, NULL, NULL)); | ||
ApplicationUwp::Get()->Inject( | ||
new ApplicationUwp::Event(kSbEventTypeReveal, NULL, NULL)); | ||
ApplicationUwp::Get()->Inject( | ||
new ApplicationUwp::Event(kSbEventTypeFocus, NULL, NULL)); | ||
} | ||
|
||
const CobaltExtensionEglContextLostHandlerApi kEglContextLostHandlerApi = { | ||
kCobaltExtensionEglContextLostHandlerName, | ||
1, | ||
&HandleEglContextLost, | ||
}; | ||
|
||
} // namespace | ||
|
||
const void* GetEglContextLostHandlerApi() { | ||
return &kEglContextLostHandlerApi; | ||
} | ||
|
||
} // namespace shared | ||
} // namespace xb1 | ||
} // namespace starboard |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Copyright 2025 The Cobalt Authors. All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#ifndef STARBOARD_XB1_SHARED_EGL_CONTEXT_LOST_HANDLER_H_ | ||
#define STARBOARD_XB1_SHARED_EGL_CONTEXT_LOST_HANDLER_H_ | ||
|
||
namespace starboard { | ||
namespace xb1 { | ||
namespace shared { | ||
|
||
const void* GetEglContextLostHandlerApi(); | ||
|
||
} // namespace shared | ||
} // namespace xb1 | ||
} // namespace starboard | ||
|
||
#endif // STARBOARD_XB1_SHARED_EGL_CONTEXT_LOST_HANDLER_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to https://github.com/youtube/cobalt/blob/main/starboard/extension/extension_test.cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an extension test.