Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore drm_system.{cc,h} #4410

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Restore drm_system.{cc,h} #4410

merged 1 commit into from
Nov 12, 2024

Conversation

dahlstrom-g
Copy link
Contributor

@dahlstrom-g dahlstrom-g commented Nov 12, 2024 •
edited
Loading

… as media/starboard/starboard_cdm.{cc,h}.

Issue: 328305808

@dahlstrom-g dahlstrom-g requested a review from a team as a code owner November 12, 2024 01:00
@johnxwork
Copy link
Contributor

Use b/xxxxxxxx to link bug number might get copybara to post a comment on the bug.

dahlstrom-g added a commit to dahlstrom-g/cobalt that referenced this pull request Nov 12, 2024
@dahlstrom-g
Restore drm_system.{cc,h}
603365c 
… as media/starboard/starboard_cdm.{cc,h}.

Issue: 328305808
Reviewed-on: youtube#4410
dahlstrom-g added a commit to dahlstrom-g/cobalt that referenced this pull request Nov 12, 2024
@dahlstrom-g
Restore drm_system.{cc,h}
adf5382 
… as media/starboard/starboard_cdm.{cc,h}.

Issue: 328305808
Reviewed-on: youtube#4410
@dahlstrom-g
Copy link
Contributor Author

Use b/xxxxxxxx to link bug number might get copybara to post a comment on the bug.

Copybara doesn't do that; Git Watcher does.
Git trailers like “Issue” and “Fixed” are canonical.
Git Watcher also matches various other patterns,
an unfortunate legacy of its development history
that causes problems for mentions in message bodies.

sideb0ard
sideb0ard approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@sideb0ard sideb0ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dahlstrom-g
Restore drm_system.{cc,h}
c215442 
… as media/starboard/starboard_cdm.{cc,h}.

Issue: 328305808
Reviewed-on: youtube#4410
@dahlstrom-g dahlstrom-g merged commit c215442 into youtube:main Nov 12, 2024
5 of 6 checks passed
@dahlstrom-g dahlstrom-g deleted the drm_system branch November 12, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideb0ard sideb0ard sideb0ard approved these changes

@xiaomings xiaomings Awaiting requested review from xiaomings

@johnxwork johnxwork Awaiting requested review from johnxwork johnxwork was automatically assigned from youtube/cobalt-3p-repository-owners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dahlstrom-g @johnxwork @sideb0ard