Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPLB] Support SetTimeZone extension on win #4288

Open
wants to merge 4 commits into
base: 25.lts.1+
Choose a base branch
from

Conversation

MarekLuxoft
Copy link
Collaborator

@MarekLuxoft MarekLuxoft commented Oct 21, 2024

In order to test SbTimeZoneGetCurrent(), we need to set a time zone first. Here we add such functionality for win32 platform (without UWP/Xbox).

Copy link

google-cla bot commented Oct 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MarekLuxoft MarekLuxoft marked this pull request as ready for review October 24, 2024 21:21
@TyHolc
Copy link
Contributor

TyHolc commented Nov 7, 2024

It looks like the win32 test failed. There's also an odd looking android failure but that doesn't seem related.

Can you also make sure to sign the CLA agreement (or if you've already signed it follow the troubleshooting steps listed there).

@TyHolc
Copy link
Contributor

TyHolc commented Nov 15, 2024

All of the win32 files look good to me if you've tested and it's working. One thing I noticed was that this might require special privileges for the application, so just verify that it works on the environment you're targeting (in this case on a windows machine but not necessarily an Xbox since you're not fixing this for UWP).

I'll leave the nplb changes to be reviewed by someone else.

@MarekLuxoft MarekLuxoft force-pushed the 301980900v3 branch 2 times, most recently from 0120f53 to 7a5e44c Compare December 11, 2024 19:06
@TyHolc
Copy link
Contributor

TyHolc commented Jan 29, 2025

I'm gonna update the branch to see if some of the failing tests will pass. If not we'll need to dig into why they're failing and confirm this PR isn't the cause before submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants