-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NPLB] Support SetTimeZone extension on win #4288
base: 25.lts.1+
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
It looks like the win32 test failed. There's also an odd looking android failure but that doesn't seem related. Can you also make sure to sign the CLA agreement (or if you've already signed it follow the troubleshooting steps listed there). |
All of the win32 files look good to me if you've tested and it's working. One thing I noticed was that this might require special privileges for the application, so just verify that it works on the environment you're targeting (in this case on a windows machine but not necessarily an Xbox since you're not fixing this for UWP). I'll leave the nplb changes to be reviewed by someone else. |
0120f53
to
7a5e44c
Compare
7a5e44c
to
3b1105a
Compare
3b1105a
to
f7d6de8
Compare
I'm gonna update the branch to see if some of the failing tests will pass. If not we'll need to dig into why they're failing and confirm this PR isn't the cause before submitting. |
In order to test SbTimeZoneGetCurrent(), we need to set a time zone first. Here we add such functionality for win32 platform (without UWP/Xbox).