Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove SB14 code" #3956

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

madhurajayaraman
Copy link
Contributor

@madhurajayaraman madhurajayaraman commented Aug 8, 2024

b/355449840

Reverts #3902

@madhurajayaraman madhurajayaraman enabled auto-merge (squash) August 8, 2024 23:17
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Aug 9, 2024

Datadog Report

Branch report: revert-3902-sb17_api_cleanup3
Commit report: 5074e6e
Test service: cobalt

✅ 0 Failed, 34443 Passed, 6 Skipped, 10m 9.88s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • DeleteExpiredPartitionedCookiesAfterTimeElapsed_GetAllCookies - CookieMonsterTest - Last Failure

    Expand for error
     ../../net/cookies/cookie_monster_unittest.cc:2372
     Expected equality of these values:
       1u
         Which is: 1
       get_cookies_callback2.cookies().size()
         Which is: 2
    

@madhurajayaraman madhurajayaraman merged commit a075f8b into main Aug 9, 2024
331 of 334 checks passed
@madhurajayaraman madhurajayaraman deleted the revert-3902-sb17_api_cleanup3 branch August 9, 2024 01:15
osagie98 pushed a commit to osagie98/cobalt that referenced this pull request Aug 9, 2024
dahlstrom-g pushed a commit that referenced this pull request Feb 6, 2025
Roll Chrome Mac PGO profile from chrome-mac-6834-1737199987-cf126707c82f5811411a05c3b67761208d1a264f-10453ec4d397daef9dddd60eee920dee4770762f.profdata to chrome-mac-6834-1737222910-aaa30023f1e92973c5cfeb5dce94419351198550-83929666c97d2053ca9d0948c7af06eb00303d70.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-stable
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium stable branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m132.try:mac-chrome
Tbr: [email protected]
Change-Id: I4fc1df10ebc8091264999d69fc62d08490b10959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6183615
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6834@{#3956}
Cr-Branched-From: 47a3549fac11ee8cb7be6606001ede605b302b9f-refs/heads/main@{#1381561}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants