Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web platform test results are not correctly checked #3055

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

sherryzy
Copy link
Contributor

@sherryzy sherryzy commented Apr 23, 2024

Found Web platform tests result are not correctly being added to the test_results. After fixed this issue, there are actually three more tests failed in all Linux builds. Disable those tests first.

b/336799788

@sherryzy sherryzy marked this pull request as draft April 23, 2024 21:25
@sherryzy sherryzy force-pushed the fix_clang_gcc branch 8 times, most recently from bf0d315 to cc3c155 Compare April 24, 2024 16:53
Found Web platform tests result are not correctly being added to
the test_results. After fixed this issue, there are actually three
more tests failed in all Linux builds. Disable those tests first.

b/336564460
@sherryzy sherryzy changed the title Fix wpt for clang-3.9 and gcc-6.3 builds Fix web platform test results are not correctly checked Apr 24, 2024
Copy link
Member

@jellefoks jellefoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@sherryzy sherryzy marked this pull request as ready for review April 24, 2024 18:14
@sherryzy sherryzy merged commit ca8456e into youtube:main Apr 24, 2024
298 of 301 checks passed
@sherryzy sherryzy added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Apr 25, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Apr 25, 2024
Found Web platform tests result are not correctly being added to the
test_results. After fixed this issue, there are actually three more
tests failed in all Linux builds. Disable those tests first.

b/336799788

(cherry picked from commit ca8456e)
sherryzy added a commit that referenced this pull request Apr 25, 2024
… checked (#3082)

Refer to the original PR: #3055

Found Web platform tests result are not correctly being added to the
test_results. After fixed this issue, there are actually three more
tests failed in all Linux builds. Disable those tests first.

b/336799788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants