Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Starboard version 13 #3035

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Remove Starboard version 13 #3035

merged 7 commits into from
Jun 5, 2024

Conversation

oxve
Copy link
Contributor

@oxve oxve commented Apr 19, 2024

b/293645066

@oxve oxve changed the base branch from 25.lts.1+ to main April 19, 2024 23:13
@oxve oxve force-pushed the delete-13 branch 3 times, most recently from 0b47713 to 4da88ef Compare April 19, 2024 23:30
gbournou
gbournou approved these changes Apr 20, 2024
View reviewed changes
cobalt/h5vcc/h5vcc_system.cc Outdated Show resolved Hide resolved
.github/workflows/evergreen.yaml Outdated Show resolved Hide resolved
@hlwarriner
Copy link
Contributor

Can you please also bump SB_MINIMUM_API_VERSION to 14 at https://github.com/youtube/cobalt/blob/main/starboard/configuration.h#L38?

@oxve oxve marked this pull request as draft May 29, 2024 20:59
@oxve
Copy link
Contributor Author

oxve commented May 29, 2024

Converting to draft until I've dealt with the comments.

gbournou
gbournou suggested changes May 29, 2024
View reviewed changes
cobalt/h5vcc/h5vcc_system.cc Outdated Show resolved Hide resolved
@oxve oxve requested a review from gbournou May 30, 2024 18:20
@oxve oxve marked this pull request as ready for review May 30, 2024 18:20
@oxve
Copy link
Contributor Author

oxve commented May 30, 2024

This is ready for a new review. I've addressed the comments and removed additional blocks that I had previously missed.

@oxve oxve enabled auto-merge (squash) May 30, 2024 20:48
y4vor
y4vor reviewed May 30, 2024
View reviewed changes
.github/workflows/evergreen.yaml Outdated Show resolved Hide resolved
starboard/nplb/player_create_test.cc Show resolved Hide resolved
starboard/nplb/player_get_preferred_output_mode_test.cc Outdated Show resolved Hide resolved
kaidokert
kaidokert approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise lgtm.

gbournou
gbournou suggested changes May 31, 2024
View reviewed changes
cobalt/h5vcc/h5vcc_system.cc Outdated Show resolved Hide resolved
@gbournou
Copy link
Contributor

Is there a corresponding CL for the //internal repo files?

@oxve oxve requested a review from gbournou May 31, 2024 19:24
@oxve oxve merged commit 48f5750 into youtube:main Jun 5, 2024
308 of 309 checks passed
@oxve oxve added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Jun 27, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 27, 2024
@oxve @anonymous1-me
Remove Starboard version 13 (#3035)
d2c565c 
b/293645066

(cherry picked from commit 48f5750)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jun 27, 2024
Merged
kaidokert pushed a commit that referenced this pull request Jun 27, 2024
@oxve @kaidokert
Remove Starboard version 13 (#3035)
d058587 
b/293645066

(cherry picked from commit 48f5750)
kaidokert pushed a commit that referenced this pull request Jun 28, 2024
@cobalt-github-releaser-bot @oxve
Cherry pick PR #3035: Remove Starboard version 13 (#3712)
dff41e9 
Refer to the original PR: #3035

b/293645066

Co-authored-by: Oscar Vestlie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbournou gbournou gbournou approved these changes

@kaidokert kaidokert kaidokert approved these changes

@y4vor y4vor y4vor approved these changes

@hlwarriner hlwarriner Awaiting requested review from hlwarriner

Assignees
No one assigned
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oxve @hlwarriner @gbournou @y4vor @kaidokert