Switch from scoped_ptr to std::unique_ptr in shared code #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbobrovnik
force-pushed
the
b291356560
branch
from
c856701 to
39a47ca
Compare
alexanderbobrovnik
force-pushed
the
b291356560
branch
from
39a47ca to
9b51c4e
Compare
alexanderbobrovnik
force-pushed
the
b291356560
branch
from
9b51c4e to
fa75497
Compare
alexanderbobrovnik
force-pushed
the
b291356560
branch
2 times, most recently
from
edab11a to
c33f3ef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2427 +/- ##
==========================================
+ Coverage 58.91% 59.83% +0.91%
==========================================
Files 1822 1830 +8
Lines 88753 88542 -211
==========================================
+ Hits 52289 52977 +688
+ Misses 36464 35565 -899 ☔ View full report in Codecov by Sentry. |
alexanderbobrovnik
force-pushed
the
b291356560
branch
3 times, most recently
from
846162e to
a68a0d9
Compare
alexanderbobrovnik
force-pushed
the
b291356560
branch
from
a68a0d9 to
10be2c3
Compare
alexanderbobrovnik
force-pushed
the
b291356560
branch
from
10be2c3 to
12bce47
Compare
kaidokert
approved these changes
Apr 19, 2024
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
Test-On-Device: True b/291356560 (cherry picked from commit f5d573a)
kaidokert
pushed a commit
that referenced
this pull request
Apr 19, 2024
…ared code (#3032) Refer to the original PR: #2427 Test-On-Device: True b/291356560 Co-authored-by: alexanderbobrovnik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test-On-Device: True
b/291356560