Test MediaCodec CB with thread #2240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
mediacodec_cb_with_thread
branch
2 times, most recently
from
8d787f4 to
dabde16
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2240 +/- ##
==========================================
- Coverage 58.52% 58.51% -0.01%
==========================================
Files 1904 1904
Lines 94537 94537
==========================================
- Hits 55324 55317 -7
- Misses 39213 39220 +7 ☔ View full report in Codecov by Sentry. |
borongc
force-pushed
the
mediacodec_cb_with_thread
branch
from
dabde16 to
fa8dcf0
Compare
Now the MediaCodec callbacks and the activity lifecycle callbacks are called on the main thread. When pausing YouTube, the MediaCodec callbacks may be blocked until the lifecycle callbacks are done. This may cause frame drops on a resource-limited device when the MediaCodec callback to notify a newly decoded frame is blocked and we run out of decoded frames. Running the MediaCodec callbacks on a handler thread could avoid this problem. Change-Id: I5ffdb1f5a582c3d01964b3f98c99d7aed211674a
b/316008643
borongc
force-pushed
the
mediacodec_cb_with_thread
branch
from
fa8dcf0 to
2e4db9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test on_device tests on PR #2044 with thread feature disabled.
b/316008643