[media] Replace instances of int64_t with base::Time #2236

osagie98 · 2024-01-18T02:21:29Z

b/319904866

Changes cval stats test to call GetValueAsString(), as the previous GetValueAsPrettyString() added unnecessary formatting to base::TimeDelta values.

b/319904866

Also fixes log bug in FormatSupportQueryMetrics from the previous commit.

Changes the TimeDeltas to instantiated from microseconds rather than milliseconds.

sideb0ard

Looks pretty straightforward.
Assuming all tests pass, LGTM

codecov · 2024-01-23T00:24:31Z

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (7153cc9) 58.53% compared to head (2fdb747) 58.53%.
Report is 32 commits behind head on main.

Files	Patch %	Lines
cobalt/media/media_module.cc	0.00%	4 Missing ⚠️
...alt/media/progressive/demuxer_extension_wrapper.cc	0.00%	4 Missing ⚠️
cobalt/media/progressive/progressive_demuxer.cc	0.00%	4 Missing ⚠️
starboard/elf_loader/program_table.cc	83.33%	3 Missing ⚠️
starboard/shared/modular/posix_mmap_wrappers.cc	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2236      +/-   ##
==========================================
- Coverage   58.53%   58.53%   -0.01%     
==========================================
  Files        1908     1904       -4     
  Lines       94585    94522      -63     
==========================================
- Hits        55369    55329      -40     
+ Misses      39216    39193      -23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

b/319904866 (cherry picked from commit 29389bb)

osagie98 added 9 commits January 17, 2024 18:16

Update cval stats to use base::Time

3081fba

Changes cval stats test to call GetValueAsString(), as the previous GetValueAsPrettyString() added unnecessary formatting to base::TimeDelta values.

Update FormatSupportQueryMetrics to use base::Time

43d89ca

b/319904866

Update SbPlayerBridge to use base::Time

0f58a89

Also fixes log bug in FormatSupportQueryMetrics from the previous commit.

Update SbPlayerInterface to use base::Time

a177d40

Update SbPlayerPipeline to use base::Time

bbf3f28

Update MediaModule and WebMediaPlayerImpl to use base::Time

4d7b22c

Fix MediaModule write duration values

18ade95

Changes the TimeDeltas to instantiated from microseconds rather than milliseconds.

Change progressive media demuxer files to use base::Time

829b12a

Clean up and formatting

2fdb747

osagie98 requested review from sideb0ard, jasonzhangxx, xiaomings and borongc January 22, 2024 23:06

sideb0ard approved these changes Jan 22, 2024

View reviewed changes

osagie98 merged commit 29389bb into youtube:main Jan 24, 2024
332 of 334 checks passed

osagie98 deleted the use-base-time branch January 24, 2024 01:58

osagie98 added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jan 24, 2024

cobalt-github-releaser-bot pushed a commit that referenced this pull request Jan 24, 2024

[media] Replace instances of int64_t with base::Time (#2236)

a54a653

b/319904866 (cherry picked from commit 29389bb)

cobalt-github-releaser-bot mentioned this pull request Jan 24, 2024

Cherry pick PR #2236: [media] Replace instances of int64_t with base::Time #2272

Closed

osagie98 removed the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[media] Replace instances of int64_t with base::Time #2236

[media] Replace instances of int64_t with base::Time #2236

osagie98 commented Jan 18, 2024

sideb0ard left a comment

codecov bot commented Jan 23, 2024

[media] Replace instances of int64_t with base::Time #2236

[media] Replace instances of int64_t with base::Time #2236

Conversation

osagie98 commented Jan 18, 2024

sideb0ard left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 23, 2024

Codecov Report